* bug#23488: 25.0.93; Modules: inconsistent return types for error reporting
@ 2016-05-09 16:49 Philipp Stephani
2019-07-28 12:45 ` Lars Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Philipp Stephani @ 2016-05-09 16:49 UTC (permalink / raw)
To: 23488
Of the module environment functions, 'copy_string_contents' is
inconsistent with all the other functions in that it returns a boolean
to indicate success/failure. All other functions only set the last
error status, to be checked with non_local_exit_check etc. This should
be made consistent, e.g. my having copy_string_contents return void.
Furthermore, the comment for copy_string_contents is incorrect. If
BUFFER is NULL, it returns true, not false.
In GNU Emacs 25.0.93.5 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8)
of 2016-04-24 built on localhost
Repository revision: 0cd2e923dba8d8c7128b0c084ce6af22069e8db5
Windowing system distributor 'The X.Org Foundation', version 11.0.11501000
System Description: Ubuntu 14.04 LTS
Configured using:
'configure --with-modules'
Configured features:
XPM JPEG TIFF GIF PNG SOUND GSETTINGS NOTIFY FREETYPE XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 MODULES
Important settings:
value of $LANG: en_US.UTF-8
locale-coding-system: utf-8-unix
Major mode: Lisp Interaction
Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Recent messages:
Load-path shadows:
None found.
Features:
(network-stream nsm starttls tls gnutls mailalias qp misearch
multi-isearch pp shadow sort mail-extr emacsbug message dired
format-spec rfc822 mml mml-sec epg epg-config mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cus-edit
cus-start cus-load wid-edit thingatpt smtpmail auth-source cl-seq eieio
byte-opt bytecomp byte-compile cl-extra cconv eieio-core cl-macs gv
gnus-util password-cache sendmail rfc2047 rfc2045 ietf-drums mm-util
help-fns help-mode easymenu cl-loaddefs pcase cl-lib mail-prsvr
mail-utils time-date mule-util tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment
elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan
thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian
slovak czech european ethiopic indian cyrillic chinese charscript
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote inotify dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty make-network-process emacs)
Memory information:
((conses 16 122688 19896)
(symbols 48 22745 0)
(miscs 40 465 314)
(strings 32 22646 4355)
(string-bytes 1 663894)
(vectors 16 22020)
(vector-slots 8 1233705 213835)
(floats 8 212 202)
(intervals 56 622 15)
(buffers 976 19)
(heap 1024 55792 1609))
--
Google Germany GmbH
Erika-Mann-Straße 33
80636 München
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den Absender und löschen
Sie die E-Mail und alle Anhänge. Vielen Dank.
This e-mail is confidential. If you are not the right addressee please do not
forward it, please inform the sender, and please erase this e-mail including
any attachments. Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#23488: 25.0.93; Modules: inconsistent return types for error reporting
2016-05-09 16:49 bug#23488: 25.0.93; Modules: inconsistent return types for error reporting Philipp Stephani
@ 2019-07-28 12:45 ` Lars Ingebrigtsen
2019-07-28 18:55 ` Philipp Stephani
0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2019-07-28 12:45 UTC (permalink / raw)
To: Philipp Stephani; +Cc: 23488
Philipp Stephani <p.stephani2@gmail.com> writes:
> Of the module environment functions, 'copy_string_contents' is
> inconsistent with all the other functions in that it returns a boolean
> to indicate success/failure. All other functions only set the last
> error status, to be checked with non_local_exit_check etc. This should
> be made consistent, e.g. my having copy_string_contents return void.
Is that possible to do at this late date? It's part of the advertised
API, I think, and changing it sounds like it'd break modules.
> Furthermore, the comment for copy_string_contents is incorrect. If
> BUFFER is NULL, it returns true, not false.
I see you've fixed this later...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#23488: 25.0.93; Modules: inconsistent return types for error reporting
2019-07-28 12:45 ` Lars Ingebrigtsen
@ 2019-07-28 18:55 ` Philipp Stephani
0 siblings, 0 replies; 3+ messages in thread
From: Philipp Stephani @ 2019-07-28 18:55 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 23488
Am So., 28. Juli 2019 um 14:45 Uhr schrieb Lars Ingebrigtsen <larsi@gnus.org>:
>
> Philipp Stephani <p.stephani2@gmail.com> writes:
>
> > Of the module environment functions, 'copy_string_contents' is
> > inconsistent with all the other functions in that it returns a boolean
> > to indicate success/failure. All other functions only set the last
> > error status, to be checked with non_local_exit_check etc. This should
> > be made consistent, e.g. my having copy_string_contents return void.
>
> Is that possible to do at this late date? It's part of the advertised
> API, I think, and changing it sounds like it'd break modules.
Yes, it's indeed way too late to change the API now.
>
> > Furthermore, the comment for copy_string_contents is incorrect. If
> > BUFFER is NULL, it returns true, not false.
>
> I see you've fixed this later...
Sounds good, feel free to close this.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-28 18:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-09 16:49 bug#23488: 25.0.93; Modules: inconsistent return types for error reporting Philipp Stephani
2019-07-28 12:45 ` Lars Ingebrigtsen
2019-07-28 18:55 ` Philipp Stephani
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.