From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#54410: One cl-defgeneric in xref.el should be cl-defmethod Date: Wed, 16 Mar 2022 00:09:23 +0100 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39715"; mail-complaints-to="usenet@ciao.gmane.io" To: 54410@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 16 00:16:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUGOl-000A32-KP for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Mar 2022 00:16:15 +0100 Original-Received: from localhost ([::1]:50286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nUGOk-0001cS-JM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Mar 2022 19:16:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUGIm-0008W3-6u for bug-gnu-emacs@gnu.org; Tue, 15 Mar 2022 19:10:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55916) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nUGIk-0005Jz-3R for bug-gnu-emacs@gnu.org; Tue, 15 Mar 2022 19:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nUGIj-0006B3-Vf for bug-gnu-emacs@gnu.org; Tue, 15 Mar 2022 19:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Mar 2022 23:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 54410 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.164738577323701 (code B ref -1); Tue, 15 Mar 2022 23:10:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Mar 2022 23:09:33 +0000 Original-Received: from localhost ([127.0.0.1]:49813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUGIG-0006AD-ML for submit@debbugs.gnu.org; Tue, 15 Mar 2022 19:09:32 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:39902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUGIF-0006A3-8Y for submit@debbugs.gnu.org; Tue, 15 Mar 2022 19:09:31 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUGIF-0007Ha-3f for bug-gnu-emacs@gnu.org; Tue, 15 Mar 2022 19:09:31 -0400 Original-Received: from [2a00:1450:4864:20::62a] (port=33365 helo=mail-ej1-x62a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nUGID-0005Ha-JF for bug-gnu-emacs@gnu.org; Tue, 15 Mar 2022 19:09:30 -0400 Original-Received: by mail-ej1-x62a.google.com with SMTP id pv16so836137ejb.0 for ; Tue, 15 Mar 2022 16:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version; bh=jJrWyVkF6JQomhaQSze4k1PeZzwYmpXFmVD6jWSU920=; b=mrwB+h17Xo17BhXKlZTY2+Fyg2kvhjYA6dqER3sn/N8lDKCKqC1cK0e9f5p5RetQ2S a5s97Zrg59r6BgvboIkwEOHk64boB4LfHXvSw9KzJ9qMIO6JAshZ7eR9Ab81xMH/i/4k wM8yF95bxEvwkd+u2wXFVqDDuPm1pyhUHVxsHRx4+iuLA66+PfPW+x9Ff9vi9QLY3ZSt 8hJ+06nTV4u5Tn1OjVJTLVa0po4i/55ZnKLRnYzRD0gCh0tRw1QI1sisAB4+01FfOt82 uo7SH7KLAF7OYc6g+WFnfODbcbLWL+VFkJ8/6Y21rHCk7Vtqmown5A087p+gXvYQezLz LRcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=jJrWyVkF6JQomhaQSze4k1PeZzwYmpXFmVD6jWSU920=; b=lZCjDbXW9dkRXGGvEb/VhrsHvj9k0XCB5GJa1gvvQpOfeLQGgbZN1AylipLy11C6Jn kEtlKgf2BMiFKR5hu2QyNLMczIkHwTnjDfqu5bx4aMzWWM2bcwQIMIBRNdBh3w3hb+lx gh0O+xM8Ob7dqazaotpbk9fMqC9XWwQcseyKrbIdzF1dmoetJw14TSMpo5VMGhPXhzoQ 0AYKmypGTkOqeeb5lZikucSNienA9D3dS8NTQ6APQjnyaTQmntI0QKq277mi9L0ClEz6 pbO4/8E2VLN5NjMZ0YgXGOKA7q2BAR8cyvuYk5Z2hSfHdZfbD8A/MDg0CcXFMQKeDQ2T obQw== X-Gm-Message-State: AOAM531qtFIrnY7iQ9lyVfpvUI9cugaZVADYNImDP+am7hXKcYHwn1mv miRrkD8YRmvq0YDCJU+qL7LmK3LzEUo= X-Google-Smtp-Source: ABdhPJzUnF+39sdElLpT5xxbI0KvXXnrAqwWKuF4XdOVl4bvIw/Y8Pe8Er4srqSiBSjyFuRlI3mlgw== X-Received: by 2002:a17:906:c048:b0:6ce:a6f5:b23a with SMTP id bm8-20020a170906c04800b006cea6f5b23amr24235353ejb.350.1647385767201; Tue, 15 Mar 2022 16:09:27 -0700 (PDT) Original-Received: from phst ([2a02:2455:2a4:dc00:7dd1:b754:ae65:7605]) by smtp.gmail.com with ESMTPSA id m21-20020a17090677d500b006df766974basm162347ejn.3.2022.03.15.16.09.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Mar 2022 16:09:26 -0700 (PDT) X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::62a (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=p.stephani2@gmail.com; helo=mail-ej1-x62a.google.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228425 Archived-At: --=-=-= Content-Type: text/plain Tags: patch Is the following patch good for the release branch? In GNU Emacs 28.0.92 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.31, cairo version 1.16.0) of 2022-03-14 Repository revision: 8e7a3f21e00649bacc01be627edd45ff01b51a33 Repository branch: emacs-28 Windowing system distributor 'The X.Org Foundation', version 11.0.12014000 System Description: Debian GNU/Linux rodete Configured using: 'configure --enable-gcc-warnings=warn-only --enable-gtk-deprecation-warnings --without-pop --with-mailutils --enable-checking=all --enable-check-lisp-object-type --with-modules 'CFLAGS=-O0 -ggdb3'' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=xref-defmethod.patch diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 2fd5e19237..aefee31897 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -220,7 +220,7 @@ xref-location-group "A match xref item describes a search result." length) -(cl-defgeneric xref-match-length ((item xref-match-item)) +(cl-defmethod xref-match-length ((item xref-match-item)) "Return the length of the match." (xref-match-item-length item)) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Liana Sebastian Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Falls Sie diese f=C3=A4lschlicherweise erhal= ten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, l=C3=B6sche= n Sie alle Kopien und Anh=C3=A4nge davon und lassen Sie mich bitte wissen, dass d= ie E-Mail an die falsche Person gesendet wurde. This e-mail is confidential. If you received this communication by mistake, please don=E2=80=99t forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. --=-=-=--