From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#39971: 28.0.50; Behavior change in flymake-diagnostic-beg/end Date: Sat, 07 Mar 2020 13:28:55 +0100 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="116563"; mail-complaints-to="usenet@ciao.gmane.io" To: 39971@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 07 13:30:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jAYav-000UER-3p for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Mar 2020 13:30:17 +0100 Original-Received: from localhost ([::1]:47802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAYat-0000Rt-Nx for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Mar 2020 07:30:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38972) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAYaj-0000RX-CB for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2020 07:30:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jAYah-0007hL-Aq for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2020 07:30:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40366) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jAYah-0007eu-2X for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2020 07:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jAYag-0007mM-Ud for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2020 07:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Mar 2020 12:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 39971 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.158358417329834 (code B ref -1); Sat, 07 Mar 2020 12:30:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Mar 2020 12:29:33 +0000 Original-Received: from localhost ([127.0.0.1]:46339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAYaD-0007l8-45 for submit@debbugs.gnu.org; Sat, 07 Mar 2020 07:29:33 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:37815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAYaA-0007kz-RN for submit@debbugs.gnu.org; Sat, 07 Mar 2020 07:29:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38772) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAYa8-0000Qb-OJ for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2020 07:29:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jAYa7-0005qB-EF for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2020 07:29:28 -0500 Original-Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:34431) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jAYa7-0005ks-7c for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2020 07:29:27 -0500 Original-Received: by mail-wr1-x42a.google.com with SMTP id z15so5478170wrl.1 for ; Sat, 07 Mar 2020 04:29:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=mBZNViso1XW7nfJvI+0n61a3ykReAbme3k3JOyubj78=; b=cW9BCr2a6zrfO2dyybKTlGNntGK981mA8dka0gBpJ5ohG2PJAPQ6xWuIrBh9OTYKMI aJVHR29KIQCz7MSezg3pOLDpxWYF0XLd21Gm2WrATGlDXLCH0fOjNx/j70X24Vsd0OGq lNjzyg+1XPGJmEBErpJ/PRdprktFx0vexT/1Des5gAAgIDPrVh4nZnfddxO6prxNereI ZISrKUtEUVtXpIrYI4v7Vb9IE0VFFy3BjGG+OhK5KZkOU296wZ35slkHg0sLwRxpIEzm 8zqtmpMYC8tNadiwp8Hi5RPJuNYhcszUzfc++fIq1zgzlhKL91UMgVMGN9Umu7lpvRXJ ODkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=mBZNViso1XW7nfJvI+0n61a3ykReAbme3k3JOyubj78=; b=PslAyo2AuApj2gZF5MZ8a+oB5SlmJJZP24glDWbeDg2naMNSrI9mSEtv13eJmQEzmR 8jCvgEgqrUtIXpMyVgGMHx6y9Ha9KjuAQ9hf97NsYzSCFUxXoEPEdSj5LUk1o/z+ulTz 2BA8aIqzBX0n+CSRT0QsW6ol+njhnteKU5cZ0uvHlby4DmKlS0gOHqIWzpxb2JQV7vwL /irAUhsIEy6PI6uS/tq2HaOdCKI82MpBqfoh/tNED+T/EmVAt8qz+zcWogJEDOB5BJWq 0Cyxgv3THpwH0j2teeZcKFC2EmpxDuurXM1wG9X5OCuJl98XerddBr09VQztDWfetobu TMgg== X-Gm-Message-State: ANhLgQ2wta6AzzUzwWfwyNMFI3xWFEmLC4hZJHzR+FwPOjfiLPjvl53P wZJZyM66wjT8a2xC6eeGlvI63Jpi X-Google-Smtp-Source: ADFU+vvCjQT2FGleWdKWkIOYpw9DyIE6R/xtvEZiSWUgNl1jQuqJC2pfMQlhh32AV1/n+2jY/9ZDxQ== X-Received: by 2002:adf:d4d1:: with SMTP id w17mr9690840wrk.206.1583584165527; Sat, 07 Mar 2020 04:29:25 -0800 (PST) Original-Received: from phst1 (85.233.42.145.dynamic.cablesurf.de. [85.233.42.145]) by smtp.gmail.com with ESMTPSA id v11sm41899489wrs.54.2020.03.07.04.29.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2020 04:29:24 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177003 Archived-At: With Emacs 26: $ emacs -Q -batch -l flymake --eval=3D'(with-temp-buffer (let ((debug-on-er= ror t) (diag (flymake-make-diagnostic (current-buffer) 1 1 (quote warning) = "foo"))) (print (flymake-diagnostic-beg diag))))' 1 With the Emacs 27 pretest: $ ./src/emacs -Q -batch -l flymake --eval=3D'(with-temp-buffer (let ((debug= -on-error t) (diag (flymake-make-diagnostic (current-buffer) 1 1 (quote war= ning) "foo"))) (print (flymake-diagnostic-beg diag))))' Debugger entered--Lisp error: (wrong-type-argument overlayp nil) overlay-start(nil) flymake-diagnostic-beg(#s(flymake--diag :buffer # :beg 1 = :end 1 :type warning :text "foo" :backend nil :data nil :overlay-properties= nil :overlay nil)) [=E2=80=A6] This was introduced in commit 5b48dab412c61980bca63a67a5d548d07e56b404. While the intention of that commit is good, I'm not sure we should make such a breaking change. Basically, the flymake-diagnostic type no longer behaves like an ordinary struct. In GNU Emacs 28.0.50 (build 10, x86_64-pc-linux-gnu, GTK+ Version 3.24.12, = cairo version 1.16.0) of 2020-02-25 Repository revision: 03c07c88d90b5747456b9d286bace2dd4a713aac Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 System Description: Debian GNU/Linux rodete Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Configured using: 'configure --enable-gcc-warnings=3Dwarn-only --enable-gtk-deprecation-warnings --without-pop --with-mailutils --enable-checking --enable-check-lisp-object-type --with-modules 'CFLAGS=3D-O0 -ggdb3'' Configured features: XPM JPEG TIFF GIF PNG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY LIBSELINUX GNUTLS FREETYPE HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS PDUMPER GMP Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils phst skeleton derived edmacro kmacro pcase ffap thingatpt url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars subr-x rx gnutls puny seq byte-opt gv bytecomp byte-compile cconv dbus xml cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 59428 8101) (symbols 48 8079 1) (strings 32 20894 1798) (string-bytes 1 679977) (vectors 16 12054) (vector-slots 8 164864 5040) (floats 8 26 33) (intervals 56 196 0) (buffers 1000 11))