From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Valtteri Vuorikoski Newsgroups: gmane.emacs.bugs Subject: bug#64577: 29.0.92; configure on NetBSD forces unstable terminfo library Date: Wed, 12 Jul 2023 17:06:08 +0300 Message-ID: References: <87v8eqrxq8.fsf@notcom.org> <837cr572jt.fsf@gnu.org> <83zg415k7c.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16373"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: NeoMutt/20230517-193-0143df-dirty Cc: 64577@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 12 16:07:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJaUy-00042O-VB for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Jul 2023 16:07:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJaUi-00016X-12; Wed, 12 Jul 2023 10:07:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJaUg-00016A-HJ for bug-gnu-emacs@gnu.org; Wed, 12 Jul 2023 10:07:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJaUg-0007xZ-9S for bug-gnu-emacs@gnu.org; Wed, 12 Jul 2023 10:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qJaUf-0000HY-Ld for bug-gnu-emacs@gnu.org; Wed, 12 Jul 2023 10:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Valtteri Vuorikoski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jul 2023 14:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64577 X-GNU-PR-Package: emacs Original-Received: via spool by 64577-submit@debbugs.gnu.org id=B64577.16891707791033 (code B ref 64577); Wed, 12 Jul 2023 14:07:01 +0000 Original-Received: (at 64577) by debbugs.gnu.org; 12 Jul 2023 14:06:19 +0000 Original-Received: from localhost ([127.0.0.1]:52706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJaTy-0000Gb-TC for submit@debbugs.gnu.org; Wed, 12 Jul 2023 10:06:19 -0400 Original-Received: from jkusti.notcom.org ([118.27.113.153]:51320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJaTx-0000GQ-8d for 64577@debbugs.gnu.org; Wed, 12 Jul 2023 10:06:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=notcom.org; s=jk; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject: Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jfORO6qb5SEeAari2gN9ZD2Il8XmT4Dh4Bpi3AsNRWY=; t=1689170777; x=1690034777; b=S+rmvTpWvh1xJVhunhTxE2WkdCXCoRGOJMXxDTdgthLjr6Anpz4FRUEf+IoW6WQD68p/iyDg+oz AeD3pqkHFFhpw1QnlO/kQi76+v36eUdQOBbVJAHtHP7yPNGw40emBvSNEripdYJZylx92s1Xmff/1 hZwxpoAXBnFYZrlzxR0ZX6SmleOgqbvErjSFF7CIzjWHi1yruR2LQnnPRLpoh5JGAWhHscVzswl8A lgDK11QqhnKQbcD1fQ/jz7vuMYlpBgmlXlF9C+TPxBzFRWas/8ARGorW661osz6BKqOrWnr9WEU2c NQSN4/jJyMIKO5Lp4geOs8lo+Wft9F5RVfpA==; Original-Received: from submission.internal (id=9cdceae8c7b5bf2d4c2c643b5341fa4197f0c084) by jkusti.notcom.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.x) (envelope-from ) id 1qJaTs-0032Kn-Ah; Wed, 12 Jul 2023 14:06:12 +0000 Original-Received: from a10d750d756b015054aa81d63d047a232e64e839 by sendhost.internal with local (Exim 4.x) (envelope-from ) id 1qJaTo-0051ob-PW; Wed, 12 Jul 2023 17:06:08 +0300 Content-Disposition: inline In-Reply-To: <83zg415k7c.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264965 Archived-At: On Wed, Jul 12, 2023 at 04:32:39PM +0300, Eli Zaretskii wrote: > So does the patch below fix the issue? > > diff --git a/configure.ac b/configure.ac > index 19575e8..21c396f 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -5212,7 +5212,7 @@ AC_DEFUN > ;; > > netbsd) > - if test "x$LIBS_TERMCAP" != "x-lterminfo"; then > + if test "x$LIBS_TERMCAP" != "x-lncurses"; then > TERMINFO=no > LIBS_TERMCAP="-ltermcap" > fi It fixes the immediate problem, yes. But I don't think this special case should stick around, since it seems relevant only to a very ancient version of NetBSD. I tried out the following patch and it turns out that the thing that causes tparam1 aborts is actually TERMINFO=no: --- a/configure.ac +++ b/configure.ac @@ -5184,7 +5184,7 @@ AC_DEFUN ## option to use it. darwin) LIBS_TERMCAP="-lncurses" ;; - gnu*) test -z "$LIBS_TERMCAP" && LIBS_TERMCAP="-lncurses" ;; + gnu*|netbsd) test -z "$LIBS_TERMCAP" && LIBS_TERMCAP="-lncurses" ;; freebsd) AC_MSG_CHECKING([whether FreeBSD is new enough to use terminfo]) @@ -5211,13 +5211,6 @@ AC_DEFUN LIBS_TERMCAP= ;; - netbsd) - if test "x$LIBS_TERMCAP" != "x-lterminfo"; then - TERMINFO=no - LIBS_TERMCAP="-ltermcap" - fi - ;; - openbsd | dragonfly) LIBS_TERMCAP="-lncurses" ;; ## hpux: Make sure we get select from libc rather than from libcurses Without ncurses installed, this produces emacs linked with libterminfo that no longer crashes with TERM=xterm-256color on NetBSD 9.3 and shows 256 colors. With ncurses installed, libncurses is used and the result is equally functional. Seems like pure win to me. If users with ancient NetBSD versions experience problems with libterminfo (that the original special case logic presumably avoided), they can install ncurses as a workaround. -Valtteri