Re: feature/tree-sitter 908aab6144: Improve tree-sitter imenu for c-mode and js-mode

Re: feature/tree-sitter 908aab6144: Improve tree-sitter imenu for c-mode and js-mode

[Randy Taylor]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

> Instead of a flat list, now categorize imenu entries into categories like "Function", "Variable", "Class", etc.

Can this be made an option? I prefer a flat list.

I don't know how it looked before, but something like:
Struct structName
Field/structName fieldA
Field/structName fieldB
Function func1
Function func2

would be even better (that's what eglot shows on a golang buffer).

BTW, typo on the js change (should be Variable):
> + ("Varieable" . ,(js--treesit-imenu-1 var-tree))

Thanks.

[-- Attachment #2: Type: text/html, Size: 2080 bytes --]

Re: feature/tree-sitter 908aab6144: Improve tree-sitter imenu for c-mode and js-mode

[Stefan Kangas]

Randy Taylor <dev@rjt.dev> writes:

>> Instead of a flat list, now categorize imenu entries into categories
>> like "Function", "Variable", "Class", etc.
>
> Can this be made an option? I prefer a flat list.
>
> I don't know how it looked before, but something like:
> Struct structName
> Field/structName fieldA
> Field/structName fieldB
> Function func1
> Function func2
>
> would be even better (that's what eglot shows on a golang buffer).

Me too.  Completing over a flat list tends to work much better with the
completion framework I use (ivy).

Re: feature/tree-sitter 908aab6144: Improve tree-sitter imenu for c-mode and js-mode

[Yuan Fu]

> On Nov 12, 2022, at 7:50 PM, Stefan Kangas <stefankangas@gmail.com> wrote:
> 
> Randy Taylor <dev@rjt.dev> writes:
> 
>>> Instead of a flat list, now categorize imenu entries into categories
>>> like "Function", "Variable", "Class", etc.
>> 
>> Can this be made an option? I prefer a flat list.
>> 
>> I don't know how it looked before, but something like:
>> Struct structName
>> Field/structName fieldA
>> Field/structName fieldB
>> Function func1
>> Function func2
>> 
>> would be even better (that's what eglot shows on a golang buffer).
> 
> Me too.  Completing over a flat list tends to work much better with the
> completion framework I use (ivy).

I suspect you two are already using a categorized imenu list. The “Struct”, “Function” are actually category labels. I think nowadays every completion framework (ivy, consult) flattens the imenu list. 

Yuan