From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: [mituharu@math.s.chiba-u.ac.jp: Re: emacs-22.1 with GTK dumps core when Gnome wigets clicked] Date: Tue, 26 Jun 2007 12:45:34 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <467A4F49.9040906@swipnet.se> <0B83D28B-95EF-4022-B447-63EA6BB3792E@raeburn.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1182829544 30271 80.91.229.12 (26 Jun 2007 03:45:44 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 26 Jun 2007 03:45:44 +0000 (UTC) Cc: raeburn@raeburn.org, emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 26 05:45:42 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1I31zp-0003PO-K0 for ged-emacs-devel@m.gmane.org; Tue, 26 Jun 2007 05:45:41 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I31zp-0000i2-1o for ged-emacs-devel@m.gmane.org; Mon, 25 Jun 2007 23:45:41 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1I31zm-0000hw-RY for emacs-devel@gnu.org; Mon, 25 Jun 2007 23:45:38 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1I31zl-0000hj-Fq for emacs-devel@gnu.org; Mon, 25 Jun 2007 23:45:38 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I31zl-0000hg-9Y for emacs-devel@gnu.org; Mon, 25 Jun 2007 23:45:37 -0400 Original-Received: from ntp.math.s.chiba-u.ac.jp ([133.82.132.2] helo=mathmail.math.s.chiba-u.ac.jp) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1I31zj-0002EI-IJ; Mon, 25 Jun 2007 23:45:36 -0400 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 4725B2C40; Tue, 26 Jun 2007 12:45:34 +0900 (JST) In-Reply-To: User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.1.50 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-kernel: NetBSD 3.0 (DF) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:73873 Archived-At: >>>>> On Mon, 25 Jun 2007 11:46:05 -0400, Richard Stallman said: > For a short-term solution, do you agree to install my patch for > Emacs 22.2? Unfortunately we couldn't notice that gmalloc.c was > thread-unsafe until very recently, and we needed an immediate > solution then (although it failed to solve the problem > actually). > I agree we need a solution for this now. I am not sure (from > following the discussion with one eye) whether your solution > actually works, or whether it needs further change, or whether (if > so) you've done the further change. > What is the status of your fix? As for the issue on the hook variables such as __malloc_hook, it will work at least as well as glibc malloc. But neither is correct in a strict sense. I've just installed my patch to the trunk and the EMACS_22_BASE branch with adding a comment below: /* Copy the value of __malloc_hook to an automatic variable in case __malloc_hook is modified in another thread between its NULL-check and the use. Note: Strictly speaking, this is not a right solution. We should use mutexes to access non-read-only variables that are shared among multiple threads. We just leave it for compatibility with glibc malloc (i.e., assignments to __malloc_hook) for now. */ YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp