From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: visible-bell patch for Mac OS X Date: Mon, 01 Feb 2010 09:41:13 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <87ljffx7zr.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1264984888 2946 80.91.229.12 (1 Feb 2010 00:41:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 1 Feb 2010 00:41:28 +0000 (UTC) Cc: Filipe Cabecinhas , emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 01 01:41:25 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NbkM0-00008I-IJ for ged-emacs-devel@m.gmane.org; Mon, 01 Feb 2010 01:41:24 +0100 Original-Received: from localhost ([127.0.0.1]:36878 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NbkM0-0001jS-19 for ged-emacs-devel@m.gmane.org; Sun, 31 Jan 2010 19:41:24 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NbkLu-0001j5-Kf for emacs-devel@gnu.org; Sun, 31 Jan 2010 19:41:18 -0500 Original-Received: from [199.232.76.173] (port=40552 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NbkLu-0001ix-AD for emacs-devel@gnu.org; Sun, 31 Jan 2010 19:41:18 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NbkLt-0007IG-3e for emacs-devel@gnu.org; Sun, 31 Jan 2010 19:41:18 -0500 Original-Received: from ntp.math.s.chiba-u.ac.jp ([133.82.132.2]:63639 helo=mathmail.math.s.chiba-u.ac.jp) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NbkLs-0007Hy-Mo for emacs-devel@gnu.org; Sun, 31 Jan 2010 19:41:16 -0500 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 22C33C0561; Mon, 1 Feb 2010 09:41:13 +0900 (JST) In-Reply-To: <87ljffx7zr.fsf@stupidchicken.com> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-operating-system: by monty-python.gnu.org: NetBSD 3.0 (DF) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:120761 Archived-At: >>>>> On Sat, 30 Jan 2010 22:34:32 -0500, Chong Yidong said: > Filipe Cabecinhas writes: >> I've made a patch to remove that ugly black rectangle >> from=A0ns_ring_bell, when visible-bell is 't. The patch makes Emacs >> behave like the X version, inverting the colors of the top and >> bottom lines, and bounces the Dock icon once if Emacs is not the >> frontmost app (which can be extended to when visible-bell is 'nil, >> if desired (just hoist it outside the if). > Thanks. Looks good, I've checked it in. 2010-01-31 Filipe Cabecinhas (tiny change) * nsterm.m (ns_ring_bell): Handle visible bell like X. The patch consists of ~80 lines. Is it considered a "tiny change"? YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp