From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Changes in revno 100600 on the emacs-23 branch
Date: Sun, 19 Jun 2011 08:46:37 +0900 [thread overview]
Message-ID: <wly60ywvmq.wl%mituharu@math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <83k4cjw0s3.fsf@gnu.org>
>>>>> On Sat, 18 Jun 2011 19:40:44 +0300, Eli Zaretskii <eliz@gnu.org> said:
>> === modified file 'src/dispnew.c'
>> --- a/src/dispnew.c 2011-05-25 03:06:05 +0000
>> +++ b/src/dispnew.c 2011-06-18 00:37:38 +0000
>> @@ -5206,6 +5206,7 @@
>> /* Copy on the display. */
>> if (r->current_y != r->desired_y)
>> {
>> + rif->clear_window_mouse_face (w);
>> rif->scroll_run_hook (w, r);
> Why do you do this inside the loop? Mouse highlight needs only be
> turned off once, right? And no code inside the loop seems to turn it
> back on, right?
The first call clears dpyinfo->mouse_face_window to Qnil inside
clear_mouse_face, and thus the subsequent calls return early. Of
course one could save the function call overhead by introducing a
local variable that differentiates the first call, but scroll_run_hook
involves graphics operations and is not light in the first place, and
I chose code similarity with the corresponding parts in try_window_id
and try_window_reusing_current_matrix.
> And btw, where's the code that will turn mouse highlight back on after
> this?
Just as in the case for try_window_id and
try_window_reusing_current_matrix, frame_up_to_date_hook will call
note_mouse_highlight.
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
prev parent reply other threads:[~2011-06-18 23:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.65.1308412813.15703.emacs-diffs@gnu.org>
2011-06-18 16:40 ` Changes in revno 100600 on the emacs-23 branch Eli Zaretskii
2011-06-18 23:46 ` YAMAMOTO Mitsuharu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wly60ywvmq.wl%mituharu@math.s.chiba-u.ac.jp \
--to=mituharu@math.s.chiba-u.ac.jp \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.