Carbon (22): PNGs broken

Carbon (22): PNGs broken

[David Reitter]

The last set of check-ins that introduces Image I/O API use in the  
Carbon port (22 branch) broke PNG display; my PNGs are all blue-on- 
white now (both in tool-bar and when loaded in a buffer).
I didn't specifically set USE_MAC_IMAGE_IO, so it is at its default  
(FALSE or not defined unless I'm mistaken).

I can make one of the PNGs available and investigate further if that's  
required.

Re: Carbon (22): PNGs broken

[YAMAMOTO Mitsuharu]

>>>>> On Sat, 3 May 2008 13:49:41 +0100, David Reitter <david.reitter@gmail.com> said:

> The last set of check-ins that introduces Image I/O API use in the
> Carbon port (22 branch) broke PNG display; my PNGs are all blue-on-
> white now (both in tool-bar and when loaded in a buffer).  I didn't
> specifically set USE_MAC_IMAGE_IO, so it is at its default (FALSE or
> not defined unless I'm mistaken).

Sounds like an endian issue if you run it on an Intel machine.
Could you try adding kCGBitmapByteOrder32Host to the last
argument of each CGBitmapContextCreate call?

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

Re: Carbon (22): PNGs broken

[David Reitter]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

I see now that Image I/O is enabled by default.

On 3 May 2008, at 15:07, YAMAMOTO Mitsuharu wrote:

> Sounds like an endian issue if you run it on an Intel machine.
> Could you try adding kCGBitmapByteOrder32Host to the last
> argument of each CGBitmapContextCreate call?

Yes, that works indeed.

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2193 bytes --]

Re: Carbon (22): PNGs broken

[YAMAMOTO Mitsuharu]

>>>>> On Sat, 3 May 2008 15:29:45 +0100, David Reitter <david.reitter@gmail.com> said:

>> Sounds like an endian issue if you run it on an Intel machine.
>> Could you try adding kCGBitmapByteOrder32Host to the last argument
>> of each CGBitmapContextCreate call?

> Yes, that works indeed.

Thanks.  I've installed the fix.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp