all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: emacs-devel@gnu.org
Subject: Truncating scroll runs that copy to where we copied to
Date: Sun, 20 Nov 2011 16:13:59 +0900	[thread overview]
Message-ID: <wlty5ztgeg.wl%mituharu@math.s.chiba-u.ac.jp> (raw)

I think that `scrolling_window' needs to truncate scroll runs that
copy to where we copied to; otherwise, `assign_row (to, from)' assigns
a previously disabled bogus row in the desired matrix when we have an
overlap in the copy destination.  Such truncation can also avoid
unnecessary copy in the actual graphics operation.

Could someone double-check the code below?

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

=== modified file 'src/dispnew.c'
*** src/dispnew.c	2011-11-19 08:39:42 +0000
--- src/dispnew.c	2011-11-20 06:44:25 +0000
***************
*** 4552,4562 ****
  	    rif->clear_window_mouse_face (w);
  	    rif->scroll_run_hook (w, r);
  
! 	    /* Invalidate runs that copy from where we copied to.  */
  	    for (j = i + 1; j < nruns; ++j)
  	      {
  		struct run *p = runs[j];
  
  		if ((p->current_y >= r->desired_y
  		     && p->current_y < r->desired_y + r->height)
  		    || (p->current_y + p->height >= r->desired_y
--- 4552,4594 ----
  	    rif->clear_window_mouse_face (w);
  	    rif->scroll_run_hook (w, r);
  
! 	    /* Truncate runs that copy to where we copied to, and
! 	       invalidate runs that copy from where we copied to.  */
  	    for (j = i + 1; j < nruns; ++j)
  	      {
  		struct run *p = runs[j];
  
+ 		if (p->nrows > 0
+ 		    && p->desired_vpos < r->desired_vpos + r->nrows
+ 		    && p->desired_vpos + p->nrows > r->desired_vpos)
+ 		  {
+ 		    if (p->desired_vpos < r->desired_vpos)
+ 		      {
+ 			p->nrows = r->desired_vpos - p->desired_vpos;
+ 			p->height = r->desired_y - p->desired_y;
+ 		      }
+ 		    else
+ 		      {
+ 			int nrows_copied = (r->desired_vpos + r->nrows
+ 					    - p->desired_vpos);
+ 
+ 			if (p->nrows <= nrows_copied)
+ 			  p->nrows = 0;
+ 			else
+ 			  {
+ 			    int height_copied = (r->desired_y + r->height
+ 						 - p->desired_y);
+ 
+ 			    p->current_vpos += nrows_copied;
+ 			    p->desired_vpos += nrows_copied;
+ 			    p->nrows -= nrows_copied;
+ 			    p->current_y += height_copied;
+ 			    p->desired_y += height_copied;
+ 			    p->height -= height_copied;
+ 			  }
+ 		      }
+ 		  }
+ 
  		if ((p->current_y >= r->desired_y
  		     && p->current_y < r->desired_y + r->height)
  		    || (p->current_y + p->height >= r->desired_y




             reply	other threads:[~2011-11-20  7:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-20  7:13 YAMAMOTO Mitsuharu [this message]
2011-11-20 18:23 ` Truncating scroll runs that copy to where we copied to Eli Zaretskii
2011-11-21  0:19   ` YAMAMOTO Mitsuharu
2011-11-21 23:50     ` David Reitter
2011-11-22  6:04       ` Eli Zaretskii
2011-11-22  6:22         ` YAMAMOTO Mitsuharu
2011-11-22  8:25           ` Eli Zaretskii
2011-11-22  8:47             ` YAMAMOTO Mitsuharu
2011-11-22  7:26         ` YAMAMOTO Mitsuharu
2011-11-22  8:52           ` Eli Zaretskii
2011-11-22  9:09             ` YAMAMOTO Mitsuharu
2011-11-22  9:54               ` Eli Zaretskii
2011-11-23  0:41                 ` YAMAMOTO Mitsuharu
2011-11-26 12:44                   ` Eli Zaretskii
2011-11-28  1:10                     ` YAMAMOTO Mitsuharu
2011-11-22  0:33 ` YAMAMOTO Mitsuharu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wlty5ztgeg.wl%mituharu@math.s.chiba-u.ac.jp \
    --to=mituharu@math.s.chiba-u.ac.jp \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.