all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Possible fix for crash in NS's tooltip showAtX:Y:for:
@ 2013-04-29 17:56 David Reitter
  2013-05-01  7:01 ` Glenn Morris
  2013-05-02  4:53 ` YAMAMOTO Mitsuharu
  0 siblings, 2 replies; 6+ messages in thread
From: David Reitter @ 2013-04-29 17:56 UTC (permalink / raw)
  To: Emacs developers

Suggest to initialize ns_tooltip as shown below.  I've been seeing occasional crash reports in Fx_show_tip (and showAtX).  This may be the culprit.  (I am not sure if variables in ObjC default to nil all the time.)
I don't have a working Bzr copy of Emacs, so apologies for posting this here.



commit 826f464359aae2461bcf4c8c986b5fb5242a9df7
Author: David Reitter <david.reitter@gmail.com>
Date:   Mon Apr 29 12:51:53 2013 -0400

    nsfns.m: initialize ns_tooltip to prevent crash
     nsfns.m (ns_tooltip): initialize.

diff --git a/src/ChangeLog b/src/ChangeLog
index 22a6cc2..7d6a620 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,7 @@
+2013-04-29  David Reitter  <david.reitter@gmail.com>
+
+	* nsfns.m (ns_tooltip): initialize.
+
 2013-04-27  Juri Linkov  <juri@jurta.org>
 
 	* callint.c (Fcall_interactively): Call `Qread_number' for
diff --git a/src/nsfns.m b/src/nsfns.m
index a483f84..8049f4e 100644
--- a/src/nsfns.m
+++ b/src/nsfns.m
@@ -88,7 +88,7 @@ Lisp_Object Qfontsize;
 /* hack for OS X file panels */
 char panelOK = 0;
 
-EmacsTooltip *ns_tooltip;
+EmacsTooltip *ns_tooltip = nil;
 
 /* Need forward declaration here to preserve organizational integrity of file */
 Lisp_Object Fx_open_connection (Lisp_Object, Lisp_Object, Lisp_Object);




^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-05-02 10:57 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-29 17:56 Possible fix for crash in NS's tooltip showAtX:Y:for: David Reitter
2013-05-01  7:01 ` Glenn Morris
2013-05-02  4:53 ` YAMAMOTO Mitsuharu
2013-05-02  5:08   ` Jan Djärv
2013-05-02  8:55     ` Andreas Schwab
2013-05-02 10:57   ` David Reitter

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.