From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: png images in tool-bar / alpha mask Date: Sun, 06 Apr 2008 23:09:59 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <6C1A0020-7B4B-4202-8757-B818A066D40A@gmail.com> <75A94D20-9656-4AD6-9A00-6C0EB26B2335@gmail.com> <71EB5929-B9CC-489C-AEFD-4E11924C49FB@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1207491023 31670 80.91.229.12 (6 Apr 2008 14:10:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 6 Apr 2008 14:10:23 +0000 (UTC) Cc: emacs-devel@gnu.org To: David Reitter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 06 16:10:55 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JiVa6-0001S4-99 for ged-emacs-devel@m.gmane.org; Sun, 06 Apr 2008 16:10:50 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JiVZS-0000tP-RX for ged-emacs-devel@m.gmane.org; Sun, 06 Apr 2008 10:10:10 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JiVZO-0000pu-54 for emacs-devel@gnu.org; Sun, 06 Apr 2008 10:10:06 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JiVZM-0000nR-Jj for emacs-devel@gnu.org; Sun, 06 Apr 2008 10:10:05 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JiVZM-0000nM-GK for emacs-devel@gnu.org; Sun, 06 Apr 2008 10:10:04 -0400 Original-Received: from ntp.math.s.chiba-u.ac.jp ([133.82.132.2] helo=mathmail.math.s.chiba-u.ac.jp) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JiVZL-00029M-Vr for emacs-devel@gnu.org; Sun, 06 Apr 2008 10:10:04 -0400 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 8151E2C40; Sun, 6 Apr 2008 23:09:59 +0900 (JST) In-Reply-To: <71EB5929-B9CC-489C-AEFD-4E11924C49FB@gmail.com> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/23.0.50 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-kernel: by monty-python.gnu.org: NetBSD 3.0 (DF) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:94488 Archived-At: >>>>> On Sun, 6 Apr 2008 14:42:08 +0100, David Reitter said: >> This is not the only place where NULL-check of img->mask is used >> for determining the existence of the image mask. At least, xdisp.c >> and macterm.c also assume that. > Yes, but doesn't that happen in order to check whether there is a > bitmap mask that will be used for something? Did you seriously test your own patch? You'll see the previous contents unerased under the alpha channel part because filling with the background color is done only when the image is considered to have a mask. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp