From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: Pretest next week Date: Fri, 06 Mar 2009 10:01:38 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <815CC60C-5993-4A22-840A-C0E18A710068@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1236301338 15208 80.91.229.12 (6 Mar 2009 01:02:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 6 Mar 2009 01:02:18 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 06 02:03:35 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LfOTP-00072K-5G for ged-emacs-devel@m.gmane.org; Fri, 06 Mar 2009 02:03:35 +0100 Original-Received: from localhost ([127.0.0.1]:58498 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LfOS3-0006NV-Sb for ged-emacs-devel@m.gmane.org; Thu, 05 Mar 2009 20:02:11 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LfORf-0005yE-C1 for emacs-devel@gnu.org; Thu, 05 Mar 2009 20:01:47 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LfORd-0005vo-Ej for emacs-devel@gnu.org; Thu, 05 Mar 2009 20:01:46 -0500 Original-Received: from [199.232.76.173] (port=44700 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LfORd-0005vc-6z for emacs-devel@gnu.org; Thu, 05 Mar 2009 20:01:45 -0500 Original-Received: from ntp.math.s.chiba-u.ac.jp ([133.82.132.2]:64266 helo=mathmail.math.s.chiba-u.ac.jp) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LfORc-0005lp-Bk for emacs-devel@gnu.org; Thu, 05 Mar 2009 20:01:44 -0500 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id A8A6D2C4A for ; Fri, 6 Mar 2009 10:01:38 +0900 (JST) In-Reply-To: <815CC60C-5993-4A22-840A-C0E18A710068@gmail.com> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-operating-system: by monty-python.gnu.org: NetBSD 3.0 (DF) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:109487 Archived-At: >>>>> On Thu, 5 Mar 2009 19:15:17 +0200, Adrian Robert said: >> In the reported case, read_socket_hook is called from the select >> (ns_select, actually) call in wait_reading_process_output, and a >> menu bar activation there leads to Lisp evaluation containing >> Faccept_process_output. > It appears that a call verify-visited-file-modtime happens for each > active menu item, which then triggers tramp to go and check on the > server. This causes a reentrant call to > wait_reading_process_output, thence a reentrant call to ns_select. > I've added a check in the latter to shortcircuit in the reentrant > case. I'm anxious whether the former reentrance (i.e., wait_reading_process_output) is safe. > I've looked at your code in the Carbon AppKit port and it seems like > your approach to handling menu events there could be applied to the > NS port. The only difference I see in your event handling is > processing all event types in one function instead of passing them > through NSApp-sendEvent: to go be distributed through ordinary Cocoa > channels to widgets. But since - sendEvent: is an interception > point, the menu events could be taken there. I vaguely remember that didn't work in some cases, maybe when Emacs is used via "Screen Sharing.app" in Leopard. Anyway you can try. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp