Re: Carbon / USE_MAC_TOOLBAR: click in tool bar doesn't raise frame

[YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>]

>>>>> On Wed, 16 Apr 2008 18:28:44 +0100, David Reitter <david.reitter@gmail.com> said:

> This affects the 22 branch Carbon build.  Begin forwarded message:

>> From: "Nathaniel Cunningham" <nathaniel.cunningham@gmail.com> Date:
>> 16 April 2008 15:07:15 BST
>> 
>> With the new tool bar in nightly builds, I find that clicking in
>> the tool bar doesn't raise the frame, whether clicking on an active
>> icon, a disabled icon, or blank bar in between.  This is counter-
>> intuitive and should be fixed if possible.

> Clicking on a disabled icon should raise the frame, while clicks on
> non-disabled icons should work as they do (standard click-through
> behavior).  This doesn't currently work.

Thanks for the report.  Could you try this?

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

Index: src/mactoolbox.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/Attic/mactoolbox.c,v
retrieving revision 1.1.2.2
diff -c -p -r1.1.2.2 mactoolbox.c
*** src/mactoolbox.c	7 Apr 2008 07:13:07 -0000	1.1.2.2
--- src/mactoolbox.c	17 Apr 2008 00:43:13 -0000
*************** XTread_socket (sd, expected, hold_quit)
*** 3560,3565 ****
--- 3558,3566 ----
  		  OSStatus err;
  		  HIViewRef ch;
  
+ 		  if (FrontNonFloatingWindow () != window_ptr)
+ 		    SelectWindow (window_ptr);
+ 
  		  err = HIViewGetViewForMouseEvent (HIViewGetRoot (window_ptr),
  						    eventRef, &ch);
  		  /* This doesn't work on Mac OS X 10.2.  */