From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: bug#5703: 23.1.92; `x-show-tip' and `tooltip-frame-parameters' do not respect `left' and `top' Date: Wed, 31 Mar 2010 08:33:25 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <87pr38rnan.fsf@stupidchicken.com> <83pr2mympy.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: dough.gmane.org 1269992033 883 80.91.229.12 (30 Mar 2010 23:33:53 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 30 Mar 2010 23:33:53 +0000 (UTC) Cc: Chong Yidong , emacs-devel@gnu.org, 5703@debbugs.gnu.org, jasonr@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 31 01:33:46 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NwkwM-0000wq-3k for ged-emacs-devel@m.gmane.org; Wed, 31 Mar 2010 01:33:46 +0200 Original-Received: from localhost ([127.0.0.1]:42185 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NwkwL-00078M-Ic for ged-emacs-devel@m.gmane.org; Tue, 30 Mar 2010 19:33:45 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NwkwG-000761-Pg for emacs-devel@gnu.org; Tue, 30 Mar 2010 19:33:40 -0400 Original-Received: from [140.186.70.92] (port=35715 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NwkwD-000749-0C for emacs-devel@gnu.org; Tue, 30 Mar 2010 19:33:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NwkwB-0006lm-W3 for emacs-devel@gnu.org; Tue, 30 Mar 2010 19:33:36 -0400 Original-Received: from mathmail.math.s.chiba-u.ac.jp ([133.82.132.2]:64548) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nwkw7-0006ke-4v; Tue, 30 Mar 2010 19:33:31 -0400 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 622F2C0557; Wed, 31 Mar 2010 08:33:25 +0900 (JST) In-Reply-To: <83pr2mympy.fsf@gnu.org> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-operating-system: by eggs.gnu.org: NetBSD 3.0 (DF) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:122945 Archived-At: >>>>> On Tue, 30 Mar 2010 16:15:37 +0300, Eli Zaretskii said: > compute_tip_xy relies on the tip frame's parameters (passed to it > through the `parms' argument) for figuring out where to display the > tooltip. But by the time compute_tip_xy is called, the `top' and > `left' parameters were already removed from `parms'. That's because > x_create_tip_frame, called a few lines before that, calls > x_figure_window_size, which sets up f->top_pos and f->left_pos from > `top' and `left', and as a side effect removes them from the frame's > parameters alist. > I see almost identical code in xfns.c versions of these functions, > so I'd be interested to hear how come the X version does not suffer > from the same problem. That's because the patch below, although it > does the job, feels a bit kludgey, and I wonder if there a cleaner > way. Because x_create_tip_frame in xfns.c makes a copy of `parms'? YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp