From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: emacs-devel@gnu.org
Subject: reducing equality tests in displaying text
Date: Fri, 23 Jan 2009 11:23:00 +0900 [thread overview]
Message-ID: <wlmydihibf.wl%mituharu@math.s.chiba-u.ac.jp> (raw)
I experimented with some performance tool and noticed that there were
frequent equality tests in displaying text. I think most of them can
safely be reduced.
1. Each call of assoc_no_quit (charset,_encoding_charset_alist) in
fontset.c can be replaced with assq_no_quit because
Vfont_encoding_charset_alist is a symbol-keyed alist.
2. Also in fontset.c:
472 if (c >= 0)
473 font_group = char_table_ref_and_range (base_fontset, c, &from, &to);
474 else
475 font_group = FONTSET_FALLBACK (base_fontset);
476 if (NILP (font_group))
477 return Qnil;
If `font_group' becomes Qnil in line 473, `from' and `to' are not
used at all. So the most of the task of char_table_ref_and_range
is wasted for this case. Because font_group == Qnil case happens
frequently, the char_table_ref_and_range call should be avoided for
this case.
3. Despite its argument name, `has_char' functions in font backend
drivers are mostly called for a font object instead of a font
entity. Some font backend drivers could make use of this fact:
e.g., ftfont_has_char can avoid frequent assoc_no_quit calls if
struct ft_font has a reference to fc_charset in ft_face_cache.
BTW, I suspect Ffontset_font is broken. I couldn't get any meaningful
result from (fontset-font t ?a), for example.
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
next reply other threads:[~2009-01-23 2:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 2:23 YAMAMOTO Mitsuharu [this message]
2009-01-27 5:26 ` reducing equality tests in displaying text Kenichi Handa
2009-01-28 0:12 ` YAMAMOTO Mitsuharu
2009-01-28 7:03 ` Kenichi Handa
2009-01-28 9:11 ` YAMAMOTO Mitsuharu
2009-01-29 0:37 ` Kenichi Handa
2009-01-29 1:46 ` YAMAMOTO Mitsuharu
2009-01-29 2:29 ` Kenichi Handa
2009-01-29 2:38 ` Jason Rumney
2009-01-29 2:46 ` Kenichi Handa
2009-02-21 6:08 ` YAMAMOTO Mitsuharu
2009-02-24 11:58 ` Kenichi Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wlmydihibf.wl%mituharu@math.s.chiba-u.ac.jp \
--to=mituharu@math.s.chiba-u.ac.jp \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.