From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: Truncating scroll runs that copy to where we copied to Date: Wed, 23 Nov 2011 09:41:18 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <8339dibqlc.fsf@gnu.org> <6D358885-0CD8-4FC0-9598-549AB7E3D4AC@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: dough.gmane.org 1322008898 17790 80.91.229.12 (23 Nov 2011 00:41:38 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 23 Nov 2011 00:41:38 +0000 (UTC) Cc: david.reitter@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 23 01:41:34 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RT0u3-0006rr-TM for ged-emacs-devel@m.gmane.org; Wed, 23 Nov 2011 01:41:32 +0100 Original-Received: from localhost ([::1]:34909 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RT0u3-0003d6-2H for ged-emacs-devel@m.gmane.org; Tue, 22 Nov 2011 19:41:31 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:46420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RT0u0-0003a5-59 for emacs-devel@gnu.org; Tue, 22 Nov 2011 19:41:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RT0tz-0007ss-9t for emacs-devel@gnu.org; Tue, 22 Nov 2011 19:41:28 -0500 Original-Received: from mathmail.math.s.chiba-u.ac.jp ([133.82.132.2]:58843) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RT0tx-0007sT-Gc; Tue, 22 Nov 2011 19:41:26 -0500 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id A453AC0561; Wed, 23 Nov 2011 09:41:21 +0900 (JST) In-Reply-To: User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-operating-system: by eggs.gnu.org: NetBSD 3.0 (DF) X-Received-From: 133.82.132.2 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:146164 Archived-At: >>>>> On Tue, 22 Nov 2011 04:54:28 -0500, Eli Zaretskii said: > If truncation indirectly prevents copying of disabled rows, then I > think at least a comment to that effect should be in the loop which > "assigns the rows". Just looking at the loop, it is not at all > apparent that only enabled rows are being assigned. Maybe we can add an assertion as well as such a comment. >> > Also, what about the unconditional setting of to->enabled_p to 1 >> > in the above loop, regardless of what was that flag in `from'? >> > Does it look right to you? >> >> In the current code, to->enabled_p seems already be set to 1 >> unconditionally. Maybe I don't understand the question. > The question was whether the current code is right when it > unconditionally sets that flag. If the `from' row is disabled, why > should its assignee `to' row be enabled? If, after your changes, a > disabled row is never assigned, then `to' will already have its > enabled_p flag set, by virtue of the assignment. Either way, > setting this flag unconditionally after the call to assign_row looks > bogus to me. (By contrast, resetting the flag in `from' looks like > TRT, at least as long as we garble it.) Ah, I misunderstood that you were proposing setting to->enabled_p to 1 unconditionally. Yes, maybe we can replace this assignment with an assertion. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp