From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: master cd88f6de4b: Adjust zero-width grapheme clusters so they are displayed (Bug#50951) Date: Tue, 27 Sep 2022 12:46:44 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <166423829576.7468.2672204708444997712@vcs2.savannah.gnu.org> <20220927002456.D4AC2C11D7D@vcs2.savannah.gnu.org> <871qrxa5z6.fsf@yahoo.com> <87wn9p8p9q.fsf@yahoo.com> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6094"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 27 05:48:54 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1od1aY-0001NA-Mb for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Sep 2022 05:48:54 +0200 Original-Received: from localhost ([::1]:33472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1od1aQ-0002am-Iv for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Sep 2022 23:48:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47126) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1od1YX-0001r8-Dm for emacs-devel@gnu.org; Mon, 26 Sep 2022 23:46:49 -0400 Original-Received: from mathmail.math.s.chiba-u.ac.jp ([133.82.132.2]:55634) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1od1YV-0004t4-4T for emacs-devel@gnu.org; Mon, 26 Sep 2022 23:46:49 -0400 Original-Received: from mathent.math.s.chiba-u.ac.jp (mathent [192.168.32.5]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 2076AF08E3; Tue, 27 Sep 2022 12:46:44 +0900 (JST) (envelope-from mituharu@math.s.chiba-u.ac.jp) In-Reply-To: <87wn9p8p9q.fsf@yahoo.com> Received-SPF: pass client-ip=133.82.132.2; envelope-from=mituharu@math.s.chiba-u.ac.jp; helo=mathmail.math.s.chiba-u.ac.jp X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296314 Archived-At: On Tue, 27 Sep 2022 12:33:37 +0900, Po Lu wrote: > > YAMAMOTO Mitsuharu writes: > > > This is a false alarm. The variable `glyph' is left uninitialized > > only when i == LGSTRING_GLYPH_LEN (gstring), and all the uses are > > guarded by this condition. So the usual practice is to add UNINIT in > > this case? > > Yes, that'd be fine. Thanks. On second thought, I made the variable always initialized and also unify the exit conditions. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp