From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: Bug in incremental undrawing of mouseover highlighting Date: Sat, 25 Nov 2006 16:28:04 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <17760.56196.739515.442009@rgrjr.dyndns.org> <87zmaludmg.fsf@cyd.mit.edu> <87hcwokvkk.fsf@furball.mit.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1164439708 15035 80.91.229.2 (25 Nov 2006 07:28:28 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 25 Nov 2006 07:28:28 +0000 (UTC) Cc: Bob Rogers , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 25 08:28:26 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GnrxW-0007aZ-SW for ged-emacs-devel@m.gmane.org; Sat, 25 Nov 2006 08:28:23 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GnrxW-0008N7-6r for ged-emacs-devel@m.gmane.org; Sat, 25 Nov 2006 02:28:22 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GnrxI-0008Mz-3f for emacs-devel@gnu.org; Sat, 25 Nov 2006 02:28:08 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GnrxG-0008Mh-M9 for emacs-devel@gnu.org; Sat, 25 Nov 2006 02:28:07 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GnrxG-0008MY-H7 for emacs-devel@gnu.org; Sat, 25 Nov 2006 02:28:06 -0500 Original-Received: from [133.82.132.2] (helo=mathmail.math.s.chiba-u.ac.jp) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GnrxG-0006Pk-2T for emacs-devel@gnu.org; Sat, 25 Nov 2006 02:28:06 -0500 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 2196C2CC2; Sat, 25 Nov 2006 16:28:04 +0900 (JST) Original-To: Chong Yidong In-Reply-To: <87hcwokvkk.fsf@furball.mit.edu> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.0.91 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62772 Archived-At: >>>>> On Fri, 24 Nov 2006 23:18:51 -0500, Chong Yidong said: >> Is it OK to refer to dpyinfo in window.c in the first place? Such >> tasks seem to be done in xdisp.c usually. > It is used in frame.c and several other files. Multiple places in these files. But no place other than your change in window.c. > I couldn't find any cleaner non-invasive solution. I'm not a redisplay expert, but I suspect whether this is a right fix. I think the usual way is to set some flag in set_window_buffer, and let some redisplay routine check the flag. Also, I think this is a bad timing to commit such a change for a non-critical bug without approval by some expert. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp