From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: Printing Date: Mon, 06 Apr 2009 17:45:01 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <5f0660120903280331y780c80b7i57a8115dc4b029eb@mail.gmail.com> <49CE3A84.9070705@swipnet.se> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1239007612 32170 80.91.229.12 (6 Apr 2009 08:46:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 6 Apr 2009 08:46:52 +0000 (UTC) Cc: emacs-devel@gnu.org To: Kenichi Handa Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 06 10:48:10 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LqkTd-0005xh-BX for ged-emacs-devel@m.gmane.org; Mon, 06 Apr 2009 10:46:46 +0200 Original-Received: from localhost ([127.0.0.1]:57047 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LqkSF-0003Sy-9s for ged-emacs-devel@m.gmane.org; Mon, 06 Apr 2009 04:45:19 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LqkS9-0003S4-U4 for emacs-devel@gnu.org; Mon, 06 Apr 2009 04:45:13 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LqkS4-0003Pq-KC for emacs-devel@gnu.org; Mon, 06 Apr 2009 04:45:12 -0400 Original-Received: from [199.232.76.173] (port=52407 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LqkS4-0003Pj-BW for emacs-devel@gnu.org; Mon, 06 Apr 2009 04:45:08 -0400 Original-Received: from ntp.math.s.chiba-u.ac.jp ([133.82.132.2]:55176 helo=mathmail.math.s.chiba-u.ac.jp) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LqkS3-0002iv-KI for emacs-devel@gnu.org; Mon, 06 Apr 2009 04:45:08 -0400 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 7C62D2C48; Mon, 6 Apr 2009 17:45:01 +0900 (JST) In-Reply-To: User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-operating-system: by monty-python.gnu.org: NetBSD 3.0 (DF) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:110087 Archived-At: >>>>> On Mon, 06 Apr 2009 17:03:18 +0900, Kenichi Handa said: > [...] > ! if (FT_Load_Char (ft_face, i, FT_LOAD_DEFAULT) == 0) > [...] > ! font->underline_thickness = ft_face->underline_thickness * size / upEM; > I've just comitted those changes. Thank you for finding > them. Does the patch contain any other fixes? Not in the patch, but I can find a similar code in xftfont.c for the latter. And maybe XFillRectangle (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f), gc, x, y - font->ascent, width, y + font->descent); in ftxfont_draw_backgrond (sic) should be XFillRectangle (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f), gc, x, y - FONT_BASE (font), width, FONT_HEIGHT (font)); What do you think about the use of GC extension data in the patch? It allows us to extract information about clipping rectangles not from struct glyph_string but from GC without using a wrapper. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp