From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: David Reitter <david.reitter@gmail.com>,
Adrian Robert <adrian.b.robert@gmail.com>,
Drew Adams <drew.adams@oracle.com>,
Emacs-Devel devel <emacs-devel@gnu.org>
Subject: Re: mouse-face highlighting broken?
Date: Thu, 07 May 2009 15:29:06 +0900 [thread overview]
Message-ID: <wld4al2zpp.wl%mituharu@math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <874ovxwmei.fsf@cyd.mit.edu>
>>>>> On Thu, 07 May 2009 00:46:13 -0400, Chong Yidong <cyd@stupidchicken.com> said:
>> With that, I took a look at the relevant code in the NS port, and
>> it turns out that ns_dumpglyphs_stretch() and ns_dumpglyphs_image()
>> fail to use the mouse face instead of the first glyph face. The
>> patch below addresses that.
> This patch looks reasonable to me.
It might be OK to apply such a change for now, but I'd rather think if
the NS port had a similar code structure to the other terms, an
oversight like this case would hardly happen in the first place. The
other terms consolidate the mouse face handling into one function
x_set_mouse_face_gc rather than scattering it into 3 (the proposed
change makes it 5) places. Also, this uniformity among different
terms makes it easier for other terms to catch up with xterm.c
changes.
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
next prev parent reply other threads:[~2009-05-07 6:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 14:05 mouse-face highlighting broken? David Reitter
2009-05-06 15:42 ` Chong Yidong
2009-05-06 17:41 ` David Reitter
2009-05-06 17:51 ` Drew Adams
2009-05-07 3:14 ` David Reitter
2009-05-07 4:46 ` Chong Yidong
2009-05-07 6:29 ` YAMAMOTO Mitsuharu [this message]
2009-05-07 13:53 ` David Reitter
2009-05-07 20:56 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wld4al2zpp.wl%mituharu@math.s.chiba-u.ac.jp \
--to=mituharu@math.s.chiba-u.ac.jp \
--cc=adrian.b.robert@gmail.com \
--cc=cyd@stupidchicken.com \
--cc=david.reitter@gmail.com \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.