From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] XCloseDisplay already calls XrmDestroyDatabase Date: Thu, 14 May 2009 08:48:56 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <19e566510808190319r454900a7sc3b5a4e9d6d68f95@mail.gmail.com> <19e566510808200117y21e78086la6240ad72b676cd7@mail.gmail.com> <19e566510808211140n56bec8e7l7ac7d6ae156e29eb@mail.gmail.com> <87k5eataqu.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1242258566 31915 80.91.229.12 (13 May 2009 23:49:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 May 2009 23:49:26 +0000 (UTC) Cc: =?UTF-8?B?xLBzbWFpbCA=?= =?ISO-8859-1?Q?D=F6nmez?= , emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 14 01:49:15 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M4OCE-0004qE-V3 for ged-emacs-devel@m.gmane.org; Thu, 14 May 2009 01:49:11 +0200 Original-Received: from localhost ([127.0.0.1]:60508 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M4OCE-0003wj-Dt for ged-emacs-devel@m.gmane.org; Wed, 13 May 2009 19:49:10 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M4OC8-0003tY-T8 for emacs-devel@gnu.org; Wed, 13 May 2009 19:49:04 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M4OC4-0003q1-C4 for emacs-devel@gnu.org; Wed, 13 May 2009 19:49:04 -0400 Original-Received: from [199.232.76.173] (port=54771 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M4OC4-0003ps-8I for emacs-devel@gnu.org; Wed, 13 May 2009 19:49:00 -0400 Original-Received: from ntp.math.s.chiba-u.ac.jp ([133.82.132.2]:55791 helo=mathmail.math.s.chiba-u.ac.jp) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M4OC3-0005Tz-Ob for emacs-devel@gnu.org; Wed, 13 May 2009 19:49:00 -0400 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 2BCCA2C40; Thu, 14 May 2009 08:48:56 +0900 (JST) In-Reply-To: User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-operating-system: by monty-python.gnu.org: NetBSD 3.0 (DF) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:110862 Archived-At: >>>>> On Wed, 13 May 2009 12:27:01 +0900, YAMAMOTO Mitsuharu said: > If we remove the XrmDestroyDatabase call unconditionally, then it > causes a memory leak when used with a newer libX11. But that would > be better than crashing when used with an older one. Or maybe we can dissociate the resource database from the display before closing it. #ifdef HAVE_XRMSETDATABASE XrmSetDatabase (dpyinfo->display, NULL); #else dpyinfo->display->db = NULL; #endif Then we can ignore the difference of libX11 at least for normal close. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp