From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: Kenichi Handa <handa@m17n.org>
Cc: 3603@emacsbugs.donarmstrong.com
Subject: bug#3603: 23.0.94; takes much time to save large non-ASCII buffers
Date: Fri, 19 Jun 2009 17:46:54 +0900 [thread overview]
Message-ID: <wl8wjoa9vl.wl%mituharu@math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <E1MHG1g-0000V3-9n@etlken>
>>>>> On Thu, 18 Jun 2009 20:43:28 +0900, Kenichi Handa <handa@m17n.org> said:
>> The slowness comes from that of select-safe-coding-system, in
>> particular, find-coding-systems-region(-internal) in it. The
>> following patch makes it much faster (a few sec.) than the current
>> version.
> It seems that your patch is correct. Actually, Emacs 22 used the
> similar method, but I forgot to implement that part when I re-wrote
> find-coding-systems-region-internal. :-(
I've installed the patch (with changing the variable name to the one
that is consistent with Emacs 22).
>> 2. If the "if (charset_map_loaded) ..." clause in
>> Ffind_coding_systems_region_internal is intended for the relocation
>> caused by GC, then maybe `chars_checked' above (and also
>> `coding_attrs_list') should be GCPROed.
> It was. But, as we modified load_charset_map_from_file to disable
> file-name-handlers a while ago, we don't need that check anymore. I
> just forgot to delete all those checks.
Thanks for the explanation. Actually, I couldn't find the part that
may cause GC, and I wondered why there's an adjustment for relocation.
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
prev parent reply other threads:[~2009-06-19 8:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 9:32 bug#3603: 23.0.94; takes much time to save large non-ASCII buffers YAMAMOTO Mitsuharu
2009-06-18 11:43 ` Kenichi Handa
2009-06-19 8:46 ` YAMAMOTO Mitsuharu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wl8wjoa9vl.wl%mituharu@math.s.chiba-u.ac.jp \
--to=mituharu@math.s.chiba-u.ac.jp \
--cc=3603@emacsbugs.donarmstrong.com \
--cc=handa@m17n.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.