From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.bugs Subject: bug#5819: 23.1.93; OSX: start-process sometimes returns an unready process Date: Fri, 09 Apr 2010 09:48:29 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: dough.gmane.org 1270774726 29892 80.91.229.12 (9 Apr 2010 00:58:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 9 Apr 2010 00:58:46 +0000 (UTC) Cc: Chong Yidong , 5819@debbugs.gnu.org To: Markus Triska Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 09 02:58:44 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O02YW-00025d-KZ for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Apr 2010 02:58:44 +0200 Original-Received: from localhost ([127.0.0.1]:52758 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O02YW-0000vT-4p for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Apr 2010 20:58:44 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O02YR-0000vO-UX for bug-gnu-emacs@gnu.org; Thu, 08 Apr 2010 20:58:39 -0400 Original-Received: from [140.186.70.92] (port=44195 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O02YQ-0000vG-8b for bug-gnu-emacs@gnu.org; Thu, 08 Apr 2010 20:58:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O02YO-0001C9-T0 for bug-gnu-emacs@gnu.org; Thu, 08 Apr 2010 20:58:38 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59154) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O02YO-0001C3-P4 for bug-gnu-emacs@gnu.org; Thu, 08 Apr 2010 20:58:36 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1O02P7-0000yF-Pd; Thu, 08 Apr 2010 20:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: YAMAMOTO Mitsuharu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Apr 2010 00:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5819 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 5819-submit@debbugs.gnu.org id=B5819.12707741203723 (code B ref 5819); Fri, 09 Apr 2010 00:49:01 +0000 Original-Received: (at 5819) by debbugs.gnu.org; 9 Apr 2010 00:48:40 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O02Ol-0000y0-47 for submit@debbugs.gnu.org; Thu, 08 Apr 2010 20:48:39 -0400 Original-Received: from mathmail.math.s.chiba-u.ac.jp ([133.82.132.2]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O02Oi-0000xt-Ge for 5819@debbugs.gnu.org; Thu, 08 Apr 2010 20:48:37 -0400 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 7864FC0557; Fri, 9 Apr 2010 09:48:29 +0900 (JST) In-Reply-To: User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 =?UTF-8?Q?(Shij=C5=8D)?= APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 08 Apr 2010 20:49:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:36107 Archived-At: >>>>> On Fri, 09 Apr 2010 00:10:09 +0200, Markus Triska said: > YAMAMOTO Mitsuharu writes: >> The following simpler one seems to work for me on 10.4 (but not on >> 10.3, again). Could you test if it also works for you, with >> respect to this problem and #726 (23.0.60; OSX: Complete OS crash)? > Your patch fixes both issues for me. Thank you very much! Thanks for testing. Maintainers, which branch should I install this patch to? Bug#726 is marked as important. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp === modified file 'src/s/darwin.h' *** src/s/darwin.h 2010-03-30 04:55:59 +0000 --- src/s/darwin.h 2010-04-05 03:21:53 +0000 *************** *** 90,95 **** --- 90,113 ---- */ #define HAVE_PTYS + /* Run only once. We need a `for'-loop because the code uses + `continue'. */ + #define PTY_ITERATION for (i = 0; i < 1; i++) + #define PTY_NAME_SPRINTF /* none */ + #define PTY_TTY_NAME_SPRINTF /* none */ + /* Note that openpty may fork via grantpt on Mac OS X 10.4/Darwin 8. + But we don't have to block SIGCHLD because it is blocked in the + implementation of grantpt. */ + #define PTY_OPEN \ + do \ + { \ + int slave; \ + if (openpty (&fd, &slave, pty_name, NULL, NULL) == -1) \ + fd = -1; \ + else \ + emacs_close (slave); \ + } \ + while (0) /** * PTYs only work correctly on Darwin 7 or higher. So make the