conjunct formation should follow input sequence when inserting text

conjunct formation should follow input sequence when inserting text

[Praveen A]

Example to illustrate this bug is അപ്‌ലോഡ് (upload).
>>> a=u'ലോഡ്'
>>> b=u'അപ്'
>>> c=u'അപ്‌ലോഡ്'
>>> print repr(c)
u'\u0d05\u0d2a\u0d4d\u200c\u0d32\u0d4b\u0d21\u0d4d'
>>> d=u'അപ്ലോ‌ഡ്'
>>> print repr(d)
u'\u0d05\u0d2a\u0d4d\u0d32\u0d4b\u200c\u0d21\u0d4d'
>>>

Here ZWNJ is added to prevent formation of conjunct 'pla' (\u0d2a\u0d4d\u0d32).

Enter ലോഡ് (\u0d32\u0d4b\u0d21\u0d4d) first, move cursor to the
beginning of the word, now enter അപ് (\u0d05\u0d2a\u0d4d). Now ZWNJ
entered will not be after 0d4d, but after the conjunct 'plo'
(\u0d2a\u0d4d\u0d32\u0d4b). gedit/pango has the correct behavior,
wherein the ZWNJ is inserted after 0d4d breaking the conjunct 'pla'
(\u0d2a\u0d4d\u0d32) as expected.

GNU Emacs 23.1.90.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.18.3)
 of 2009-12-18 on savannah
-- 
പ്രവീണ്‍ അരിമ്പ്രത്തൊടിയില്‍
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
Join The DRM Elimination Crew Now!
http://fci.wikia.com/wiki/Anti-DRM-Campaign

-- 
സ്വതന്ത്ര മലയാളം കമ്പ്യൂട്ടിങ്ങ് - എന്റെ കമ്പ്യൂട്ടറിനു് എന്റെ ഭാഷ 
സംരംഭം: https://savannah.nongnu.org/projects/smc
വെബ്‌സൈറ്റ് : http://smc.org.in  IRC ചാനല്‍ : #smc-project @ freenode
പിരിഞ്ഞു പോകാന്‍: smc-discuss-unsubscribe@googlegroups.com

bug#5256: conjunct formation should follow input sequence when inserting text

[Kenichi Handa]

In article <3f2beab60912210723x4f424fa9l2b842824aff1a546@mail.gmail.com>, Praveen A <pravi.a@gmail.com> writes:

> Example to illustrate this bug is അപ്‌ലോഡ് (upload).
>>>> a=u'ലോഡ്'
>>>> b=u'അപ്'
>>>> c=u'അപ്‌ലോഡ്'
>>>> print repr(c)
> u'\u0d05\u0d2a\u0d4d\u200c\u0d32\u0d4b\u0d21\u0d4d'
>>>> d=u'അപ്ലോ‌ഡ്'
>>>> print repr(d)
> u'\u0d05\u0d2a\u0d4d\u0d32\u0d4b\u200c\u0d21\u0d4d'
>>>> 

> Here ZWNJ is added to prevent formation of conjunct 'pla' (\u0d2a\u0d4d\u0d32).

> Enter ലോഡ് (\u0d32\u0d4b\u0d21\u0d4d) first, move cursor to the
> beginning of the word, now enter അപ് (\u0d05\u0d2a\u0d4d). Now ZWNJ
> entered will not be after 0d4d, but after the conjunct 'plo'
> (\u0d2a\u0d4d\u0d32\u0d4b). gedit/pango has the correct behavior,
> wherein the ZWNJ is inserted after 0d4d breaking the conjunct 'pla'
> (\u0d2a\u0d4d\u0d32) as expected.

Ah, I see your point.  It seems that we must set
disable-point-adjustment to t when a character/string is
inserted in a buffer.  I'll work on it.

---
Kenichi Handa
handa@m17n.org

bug#5256: conjunct formation should follow input sequence when inserting text

[Kenichi Handa]

In article <tl7fx73dvfp.fsf@m17n.org>, Kenichi Handa <handa@m17n.org> writes:

> In article <3f2beab60912210723x4f424fa9l2b842824aff1a546@mail.gmail.com>, Praveen A <pravi.a@gmail.com> writes:
> > Example to illustrate this bug is അപ്‌ലോഡ് (upload).
>>>>> a=u'ലോഡ്'
>>>>> b=u'അപ്'
>>>>> c=u'അപ്‌ലോഡ്'
>>>>> print repr(c)
> > u'\u0d05\u0d2a\u0d4d\u200c\u0d32\u0d4b\u0d21\u0d4d'
>>>>> d=u'അപ്ലോ‌ഡ്'
>>>>> print repr(d)
> > u'\u0d05\u0d2a\u0d4d\u0d32\u0d4b\u200c\u0d21\u0d4d'
>>>>> 

> > Here ZWNJ is added to prevent formation of conjunct 'pla' (\u0d2a\u0d4d\u0d32).

> > Enter ലോഡ് (\u0d32\u0d4b\u0d21\u0d4d) first, move cursor to the
> > beginning of the word, now enter അപ് (\u0d05\u0d2a\u0d4d). Now ZWNJ
> > entered will not be after 0d4d, but after the conjunct 'plo'
> > (\u0d2a\u0d4d\u0d32\u0d4b). gedit/pango has the correct behavior,
> > wherein the ZWNJ is inserted after 0d4d breaking the conjunct 'pla'
> > (\u0d2a\u0d4d\u0d32) as expected.

> Ah, I see your point.  It seems that we must set
> disable-point-adjustment to t when a character/string is
> inserted in a buffer.  I'll work on it.

I fixed it.  Please try again with the lastest code.

---
Kenichi Handa
handa@m17n.org

bug#5256: conjunct formation should follow input sequence when inserting text

[YAMAMOTO Mitsuharu]

>>>>> On Fri, 25 Dec 2009 11:48:13 +0900, Kenichi Handa <handa@m17n.org> said:

>> Ah, I see your point.  It seems that we must set
>> disable-point-adjustment to t when a character/string is inserted
>> in a buffer.  I'll work on it.

> I fixed it.  Please try again with the lastest code.

It seems to crash on undo.

Steps to reproduce.

  1. emacs -Q
  2. C-x u

(gdb) bt
#0  0x9266be42 in __kill ()
#1  0x9266be34 in kill$UNIX2003 ()
#2  0x926de23a in raise ()
#3  0x926ea679 in abort ()
#4  0x0022bd07 in buf_charpos_to_bytepos (b=0xd01678, charpos=192) at .../emacs/src/marker.c:141
#5  0x003a5f27 in find_automatic_composition (pos=192, limit=-1, start=0xbffff414, end=0xbffff410, gstring=0xbffff40c, string=33554442) at .../emacs/src/composite.c:1310
#6  0x003a9ed1 in composition_adjust_point (last_pt=192, new_pt=192) at .../emacs/src/composite.c:1485
#7  0x001cbbaa in command_loop_1 () at .../emacs/src/keyboard.c:1981
#8  0x002c727e in internal_condition_case (bfun=0x1c713d <command_loop_1>, handlers=33588914, hfun=0x1c64f4 <cmd_error>) at .../emacs/src/eval.c:1490
#9  0x001c6bd6 in command_loop_2 () at .../emacs/src/keyboard.c:1360
#10 0x002c6b0e in internal_catch (tag=33586058, func=0x1c6ba1 <command_loop_2>, arg=33554442) at .../emacs/src/eval.c:1226
#11 0x001c6b5f in command_loop () at .../emacs/src/keyboard.c:1339
#12 0x001c5916 in recursive_edit_1 () at .../emacs/src/keyboard.c:954
#13 0x001c5fc2 in Frecursive_edit () at .../emacs/src/keyboard.c:1016
#14 0x001c3598 in main (argc=2, argv=0xbffff958) at .../emacs/src/emacs.c:1833

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

In GNU Emacs 23.1.90.1 (i386-apple-darwin9.8.0, X toolkit, Xaw3d scroll bars)
 of 2009-12-25 on yamamoto-mitsuharu-no-mac-mini.local
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
configured using `configure  '--with-x' '--without-gif' '--without-jpeg' '--without-tiff' 'CFLAGS=-g -Wno-pointer-sign -DENABLE_CHECKING''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ja_JP.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

bug#5256: conjunct formation should follow input sequence when inserting text

[Kenichi Handa]

In article <wl7hsbhfdf.wl%mituharu@math.s.chiba-u.ac.jp>, YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> writes:

>>>>>> On Fri, 25 Dec 2009 11:48:13 +0900, Kenichi Handa <handa@m17n.org> said:
>>> Ah, I see your point.  It seems that we must set
>>> disable-point-adjustment to t when a character/string is inserted
>>> in a buffer.  I'll work on it.

> > I fixed it.  Please try again with the lastest code.

> It seems to crash on undo.

Sorry, I've just installed a fix.

---
Kenichi Handa
handa@m17n.org

bug#5256: conjunct formation should follow input sequence when inserting text

[Kenichi Handa]

In article <3f2beab60912210723x4f424fa9l2b842824aff1a546@mail.gmail.com>, Praveen A <pravi.a@gmail.com> writes:

> Example to illustrate this bug is അപ്‌ലോഡ് (upload).
>>>> a=u'ലോഡ്'
>>>> b=u'അപ്'
>>>> c=u'അപ്‌ലോഡ്'

I have one question.  Emacs tries hard to find a grapheme
boundary to put cursor on.  For instance, in the above (c)
string, when you put cursor on the second character പ
(U+D2A) and type C-f, the cursor moves to ലോ (U+D32 U+D4B),
and the next C-f moves the cursor to ഡ (U+D21).

But, in gedit, "പ്‌ലോ" is treated as one cluster and you
can't put cursor between "പ്‌" and "ലോ".

Which is convenient for Malayalam user?

---
Kenichi Handa
handa@m17n.org

bug#5256: conjunct formation should follow input sequence when inserting text

[Praveen A]

2009/12/25 Kenichi Handa <handa@m17n.org>:
> I have one question.  Emacs tries hard to find a grapheme
> boundary to put cursor on.  For instance, in the above (c)
> string, when you put cursor on the second character പ
> (U+D2A) and type C-f, the cursor moves to ലോ (U+D32 U+D4B),
> and the next C-f moves the cursor to ഡ (U+D21).
>
> But, in gedit, "പ്‌ലോ" is treated as one cluster and you
> can't put cursor between "പ്‌" and "ലോ".
>
> Which is convenient for Malayalam user?

emacs way is convenient. I will test the latest code by Monday. Thanks again.

- Praveen
-- 
പ്രവീണ്‍ അരിമ്പ്രത്തൊടിയില്‍
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
Join The DRM Elimination Crew Now!
http://fci.wikia.com/wiki/Anti-DRM-Campaign

bug#5256: marked as done (conjunct formation should follow input sequence when inserting text)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 924 bytes --]

Your message dated Mon, 28 Dec 2009 15:08:20 +0530
with message-id <3f2beab60912280138i6348afc0h53c3349aca24c7f@mail.gmail.com>
and subject line Re: bug#5256: conjunct formation should follow input sequence when  inserting text
has caused the Emacs bug report #5256,
regarding conjunct formation should follow input sequence when inserting text
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact bug-gnu-emacs@gnu.org
immediately.)


-- 
5256: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5256
Emacs Bug Tracking System
Contact bug-gnu-emacs@gnu.org with problems

[-- Attachment #2: Type: message/rfc822, Size: 6058 bytes --]

From: Praveen A <pravi.a@gmail.com>
To: bug-gnu-emacs@gnu.org
Cc: psatpute@redhat.com, Parag Nemade <pnemade@redhat.com>, suresh <surumafonts@gmail.com>
Subject: conjunct formation should follow input sequence when inserting text
Date: Mon, 21 Dec 2009 20:53:41 +0530
Message-ID: <3f2beab60912210723x4f424fa9l2b842824aff1a546@mail.gmail.com>

Example to illustrate this bug is അപ്‌ലോഡ് (upload).
>>> a=u'ലോഡ്'
>>> b=u'അപ്'
>>> c=u'അപ്‌ലോഡ്'
>>> print repr(c)
u'\u0d05\u0d2a\u0d4d\u200c\u0d32\u0d4b\u0d21\u0d4d'
>>> d=u'അപ്ലോ‌ഡ്'
>>> print repr(d)
u'\u0d05\u0d2a\u0d4d\u0d32\u0d4b\u200c\u0d21\u0d4d'
>>>

Here ZWNJ is added to prevent formation of conjunct 'pla' (\u0d2a\u0d4d\u0d32).

Enter ലോഡ് (\u0d32\u0d4b\u0d21\u0d4d) first, move cursor to the
beginning of the word, now enter അപ് (\u0d05\u0d2a\u0d4d). Now ZWNJ
entered will not be after 0d4d, but after the conjunct 'plo'
(\u0d2a\u0d4d\u0d32\u0d4b). gedit/pango has the correct behavior,
wherein the ZWNJ is inserted after 0d4d breaking the conjunct 'pla'
(\u0d2a\u0d4d\u0d32) as expected.

GNU Emacs 23.1.90.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.18.3)
 of 2009-12-18 on savannah
-- 
പ്രവീണ്‍ അരിമ്പ്രത്തൊടിയില്‍
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
Join The DRM Elimination Crew Now!
http://fci.wikia.com/wiki/Anti-DRM-Campaign




[-- Attachment #3: Type: message/rfc822, Size: 3565 bytes --]

From: Praveen A <pravi.a@gmail.com>
To: Kenichi Handa <handa@m17n.org>
Cc: 5256-done@debbugs.gnu.org
Subject: Re: bug#5256: conjunct formation should follow input sequence when  inserting text
Date: Mon, 28 Dec 2009 15:08:20 +0530
Message-ID: <3f2beab60912280138i6348afc0h53c3349aca24c7f@mail.gmail.com>

2009/12/25 Kenichi Handa <handa@m17n.org>:
> I fixed it.  Please try again with the lastest code.

Thanks. I tested it and it is working beautifully.

- Praveen
-- 
പ്രവീണ്‍ അരിമ്പ്രത്തൊടിയില്‍
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
Join The DRM Elimination Crew Now!
http://fci.wikia.com/wiki/Anti-DRM-Campaign