From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: GDB on Mac is (NOT) Broken Date: Sat, 20 Mar 2010 13:10:45 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <19357.53872.672127.600861@totara.tehura.co.nz> <19359.5799.721358.312552@totara.tehura.co.nz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: dough.gmane.org 1269058332 10090 80.91.229.12 (20 Mar 2010 04:12:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 20 Mar 2010 04:12:12 +0000 (UTC) Cc: emacs-devel@gnu.org To: nickrob@snap.net.nz (Nick Roberts) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 20 05:12:08 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Nsq1n-0005EU-Qx for ged-emacs-devel@m.gmane.org; Sat, 20 Mar 2010 05:12:08 +0100 Original-Received: from localhost ([127.0.0.1]:35658 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nsq1b-0004sb-Me for ged-emacs-devel@m.gmane.org; Sat, 20 Mar 2010 00:10:59 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nsq1X-0004sC-1P for emacs-devel@gnu.org; Sat, 20 Mar 2010 00:10:55 -0400 Original-Received: from [140.186.70.92] (port=53991 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nsq1U-0004rX-RY for emacs-devel@gnu.org; Sat, 20 Mar 2010 00:10:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nsq1S-00005f-1D for emacs-devel@gnu.org; Sat, 20 Mar 2010 00:10:51 -0400 Original-Received: from mathmail.math.s.chiba-u.ac.jp ([133.82.132.2]:57545) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nsq1R-00004t-PV for emacs-devel@gnu.org; Sat, 20 Mar 2010 00:10:49 -0400 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 211FDC0557; Sat, 20 Mar 2010 13:10:45 +0900 (JST) In-Reply-To: <19359.5799.721358.312552@totara.tehura.co.nz> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-operating-system: by eggs.gnu.org: NetBSD 3.0 (DF) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:122339 Archived-At: >>>>> On Tue, 16 Mar 2010 18:27:03 +1300, nickrob@snap.net.nz (Nick Roberts) said: >> *************** >> *** 1769,1774 **** >> --- 1781,1792 ---- >> (progn >> (setq output (gdb-concat-output output gud-marker-acc)) >> (setq gud-marker-acc ""))) >> + (if (not (string-match "\n" gdb-first-output-line)) > (if (gdb-first-post-prompt) > would probably also work I guess you meant "(if gdb-first-prompt", but whichever the variables, I think its value might be changed in the while-loop in gud-gdba-marker-filter via annotation handler calls. If we want to avoid string-match for most cases, then we can save the original value at the beginning of the while-loop to some variable (say, orig-gdb-first-prompt) and use it like this: (if (and orig-gdb-first-prompt (not (string-match "\n" gdb-first-output-line))) but it looks too much to me. BTW, which branch should the patch go to, emacs-23 or trunk? YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp