From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Nick Roberts <nickrob@snap.net.nz>, emacs-devel@gnu.org
Subject: Re: GDB on Mac is (NOT) Broken
Date: Sun, 21 Mar 2010 13:43:36 +0900 [thread overview]
Message-ID: <wl39zup9mv.wl%mituharu@math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <jwvy6hmaieq.fsf-monnier+emacs@gnu.org>
>>>>> On Sat, 20 Mar 2010 15:45:59 -0400, Stefan Monnier <monnier@iro.umontreal.ca> said:
>> + ;; Workaround for some Apple versions of GDB that add ^M at EOL
>> + ;; after the command "server interpreter mi -stack-info-frame".
>> + (if (string-match "(Apple version " gdb-first-output-line)
>> + (let* ((process (get-buffer-process gud-comint-buffer))
>> + (coding-systems (process-coding-system process)))
>> + (set-process-coding-system process
>> + (coding-system-change-eol-conversion
>> + (car coding-systems) 'dos)
>> + (cdr coding-systems))))
>> +
> Actually, detecting the CRLF itself would be better. But at least this
> seems "safe for GNU". So I think it's acceptable for 23.2.
Strangely, the EOL style suddenly changes from LF to CRLF after the
command "server interpreter mi -stack-info-frame", . I.e., the first
output line ends with LF. Maybe I'll improve the comment.
>> + (if (not (string-match "\n" gdb-first-output-line))
>> + (setq gdb-first-output-line
>> + (concat gdb-first-output-line
>> + (if (string-match "\n" output)
>> + (substring output 0 (match-end 0))
>> + output))))
>> output)))
> Rather than string-match, you can
> (eq ?\n (aref gdb-first-output-line (1- (length gdb-first-output-line))))
Currently, gdb-first-output-line is initialized to "". And I thought
(and (not (string= gdb-first-output-line "")
(eq ?\n (aref gdb-first-output-line
(1- (length gdb-first-output-line))))
a bit awkward and doubted its merit because it involves more
bytecode-level operations. Of course, one can initialize the variable
to some dummy non-empty string, but it doesn't look natural.
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
next prev parent reply other threads:[~2010-03-21 4:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 6:23 GDB on Mac is (NOT) Broken Nick Roberts
2010-03-15 16:39 ` Chad Brown
2010-03-15 20:17 ` Nick Roberts
2010-03-16 0:18 ` YAMAMOTO Mitsuharu
2010-03-16 2:59 ` Steve Revilak
2010-03-16 5:27 ` Nick Roberts
2010-03-16 8:55 ` Chad Brown
2010-03-16 21:00 ` Nick Roberts
2010-03-20 4:10 ` YAMAMOTO Mitsuharu
2010-03-21 6:50 ` Nick Roberts
2010-03-22 1:29 ` YAMAMOTO Mitsuharu
2010-03-22 2:32 ` Nick Roberts
2010-03-22 2:46 ` Stefan Monnier
2010-03-22 3:04 ` Nick Roberts
2010-03-22 13:43 ` Stefan Monnier
2010-03-22 20:55 ` Nick Roberts
2010-03-23 1:13 ` Stefan Monnier
2010-03-23 1:55 ` YAMAMOTO Mitsuharu
2010-03-23 2:38 ` Nick Roberts
2010-03-23 3:12 ` Stefan Monnier
2010-03-26 9:02 ` Nick Roberts
2010-03-26 20:20 ` Stefan Monnier
2010-03-27 1:00 ` YAMAMOTO Mitsuharu
2010-03-17 13:30 ` Leo
2010-03-20 19:45 ` Stefan Monnier
2010-03-21 4:43 ` YAMAMOTO Mitsuharu [this message]
[not found] <20100314185409.00EDD9B718@mxperim5.sea5.speakeasy.net>
2010-03-15 2:43 ` Steve Revilak
-- strict thread matches above, loose matches on Subject: below --
2010-03-14 0:32 Nick Roberts
2010-03-14 19:45 ` Harald Hanche-Olsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wl39zup9mv.wl%mituharu@math.s.chiba-u.ac.jp \
--to=mituharu@math.s.chiba-u.ac.jp \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.