From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.60; Image in before-string of overlay interferes with keymap Date: Fri, 29 Feb 2008 19:06:58 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <87fxw593iu.fsf@photon.caeruleus.net> <877igsewqi.fsf@photon.caeruleus.net> <87zltklx7k.fsf@photon.caeruleus.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1204280433 12394 80.91.229.12 (29 Feb 2008 10:20:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Feb 2008 10:20:33 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, rms@gnu.org To: Ralf Angeli Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 29 11:20:59 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JV2MF-0007fs-67 for ged-emacs-devel@m.gmane.org; Fri, 29 Feb 2008 11:20:51 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JV2Li-0005yz-7l for ged-emacs-devel@m.gmane.org; Fri, 29 Feb 2008 05:20:18 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JV28y-0002sV-6g for emacs-devel@gnu.org; Fri, 29 Feb 2008 05:07:08 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JV28v-0002oi-Uj for emacs-devel@gnu.org; Fri, 29 Feb 2008 05:07:06 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JV28v-0002nk-9W for emacs-devel@gnu.org; Fri, 29 Feb 2008 05:07:05 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JV28u-0000Nk-RH for emacs-devel@gnu.org; Fri, 29 Feb 2008 05:07:05 -0500 Original-Received: from mx10.gnu.org ([199.232.76.166]) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1JV28u-0001Yf-Go for emacs-pretest-bug@gnu.org; Fri, 29 Feb 2008 05:07:04 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JV28q-0000Le-GF for emacs-pretest-bug@gnu.org; Fri, 29 Feb 2008 05:07:04 -0500 Original-Received: from mathmail.math.s.chiba-u.ac.jp ([133.82.132.2]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JV28p-0000L0-MO; Fri, 29 Feb 2008 05:07:00 -0500 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 05E692C46; Fri, 29 Feb 2008 19:06:58 +0900 (JST) In-Reply-To: <87zltklx7k.fsf@photon.caeruleus.net> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/23.0.50 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-kernel: by monty-python.gnu.org: NetBSD 3.0 (DF) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:90854 gmane.emacs.pretest.bugs:21350 Archived-At: >>>>> On Thu, 28 Feb 2008 20:03:59 +0100, Ralf Angeli said: > I could narrow down the problematic part of the change. If the > following part of the patch (diff between revision 1.1170 and 1.1171 of > xdisp.c) is reverted, the test case I sent in my original report will > work again. > @@ -4245,7 +4260,8 @@ > /* Say that we haven't consumed the characters with > `display' property yet. The call to pop_it in > set_iterator_to_next will clean this up. */ > - *position = start_pos; > + if (BUFFERP (object)) > + it->current.pos = start_pos; > } > #endif /* HAVE_WINDOW_SYSTEM */ > The test case Joe sent in his report will work as well, but this is > likely only due to the fact that the part shown above is not related to > strings (where an analogous change was made.) Nice observation. I changed all the cases where a (overlay) string is replaced as an effect of some `display' property (string, space, or image) because that looks more consistent. But that introduced the problem you described. The crucial case in Joe's report was string-replacing-string one, so the other cases can be reverted. > Could somebody please help me fix this before Emacs 22.2 is released? > I'd hate to see preview-latex broken until the successor of 22.2 will > be released. I agree with you. If nobody objects, I'll revert the changes about the space and image cases in the EMACS_22_BASE branch. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp