Re: 23.0.60; Image in before-string of overlay interferes with keymap

[YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>]

>>>>> On Thu, 28 Feb 2008 20:03:59 +0100, Ralf Angeli <angeli@caeruleus.net> said:

> I could narrow down the problematic part of the change.  If the
> following part of the patch (diff between revision 1.1170 and 1.1171 of
> xdisp.c) is reverted, the test case I sent in my original report will
> work again.

> @@ -4245,7 +4260,8 @@
>  	  /* Say that we haven't consumed the characters with
>  	     `display' property yet.  The call to pop_it in
>  	     set_iterator_to_next will clean this up.  */
> -	  *position = start_pos;
> +	  if (BUFFERP (object))
> +	    it->current.pos = start_pos;
>  	}
>  #endif /* HAVE_WINDOW_SYSTEM */
 
> The test case Joe sent in his report will work as well, but this is
> likely only due to the fact that the part shown above is not related to
> strings (where an analogous change was made.)

Nice observation.  I changed all the cases where a (overlay) string is
replaced as an effect of some `display' property (string, space, or
image) because that looks more consistent.  But that introduced the
problem you described.  The crucial case in Joe's report was
string-replacing-string one, so the other cases can be reverted.

> Could somebody please help me fix this before Emacs 22.2 is released?
> I'd hate to see preview-latex broken until the successor of 22.2 will
> be released.

I agree with you.  If nobody objects, I'll revert the changes about
the space and image cases in the EMACS_22_BASE branch.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp