From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: visible-bell patch for Mac OS X Date: Sat, 13 Feb 2010 10:30:44 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <87ljffx7zr.fsf@stupidchicken.com> <87bpg90x1s.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1266024757 3423 80.91.229.12 (13 Feb 2010 01:32:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 13 Feb 2010 01:32:37 +0000 (UTC) Cc: Filipe Cabecinhas , emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 13 02:32:34 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ng6s4-0003hu-TM for ged-emacs-devel@m.gmane.org; Sat, 13 Feb 2010 02:32:33 +0100 Original-Received: from localhost ([127.0.0.1]:41443 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ng6s3-0000nt-TJ for ged-emacs-devel@m.gmane.org; Fri, 12 Feb 2010 20:32:31 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ng6qS-0000D5-1W for emacs-devel@gnu.org; Fri, 12 Feb 2010 20:30:52 -0500 Original-Received: from [140.186.70.92] (port=42484 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ng6qR-0000Cp-C4 for emacs-devel@gnu.org; Fri, 12 Feb 2010 20:30:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ng6qQ-0006F8-AJ for emacs-devel@gnu.org; Fri, 12 Feb 2010 20:30:51 -0500 Original-Received: from ntp.math.s.chiba-u.ac.jp ([133.82.132.2]:64213 helo=mathmail.math.s.chiba-u.ac.jp) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ng6qP-0006Eh-Qm for emacs-devel@gnu.org; Fri, 12 Feb 2010 20:30:50 -0500 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id AA0C1C0557; Sat, 13 Feb 2010 10:30:44 +0900 (JST) In-Reply-To: User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-operating-system: by eggs.gnu.org: NetBSD 3.0 (DF) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:121086 Archived-At: >>>>> On Tue, 02 Feb 2010 08:33:22 +0900, YAMAMOTO Mitsuharu said: >> YAMAMOTO Mitsuharu writes: >>> The patch consists of ~80 lines. Is it considered a "tiny >>> change"? >> I have started the copyright assignment process with Filipe. > Besides that, I'd suggest reverting the patch for now for several > reasons: it does not work on the second frame, it gives inconsistent > flashed area when the scroll bars are placed on the left side, and > it breaks GNUstep builds. Bug#5569 confirms the last issue. It also breaks build on Mac OS X 10.4 because of the lack of NSRectToCGRect. BTW, I noticed that the GTK+ build may also flash part of scroll bars if GDK_NATIVE_WINDOWS is not set. One can argue that the current behavior of Emacs 22 Carbon(+AppKit) port and Emacs 23 Mac port is compatible with this :-p (though I'm planning to change this behavior in the next releases of the Mac port). YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp