From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: Ulf Jasper <ulf.jasper@web.de>
Cc: Vasilij Schneidermann <hurrus.durrus@gmail.com>, 19373@debbugs.gnu.org
Subject: bug#19373: 24.4; SVG images rendered via librsvg fail at displaying non-inline bitmap images
Date: Thu, 18 Dec 2014 12:50:33 +0900 [thread overview]
Message-ID: <wl1tnx62gm.wl%mituharu@math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <87k31q3v2h.fsf@web.de>
>>>>> On Wed, 17 Dec 2014 21:00:54 +0100, Ulf Jasper <ulf.jasper@web.de> said:
> This is related to rsvg bug 596114 "image refs are relative to
> curdir, not .svg file" [2]. I just pushed a fix to master (c17c864)
> which should fix this.
I suspect it is not appropriate to refer to buffer-local variables of
the current buffer inside image loading functions:
diff --git a/src/image.c b/src/image.c
index 1a2c0e2..0bebd45 100644
[snip]
@@ -8818,7 +8822,9 @@ svg_load (struct frame *f, struct image *img)
image_error ("Invalid image data `%s'", data, Qnil);
return 0;
}
- success_p = svg_load_image (f, img, SDATA (data), SBYTES (data));
+ original_filename = BVAR (current_buffer, filename);
+ success_p = svg_load_image (f, img, SDATA (data), SBYTES (data),
+ SDATA(original_filename));
}
return success_p;
Maybe SVG image descriptors should accept the property `:base-uri' or
something?
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
next prev parent reply other threads:[~2014-12-18 3:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-13 19:35 bug#19373: 24.4; SVG images rendered via librsvg fail at displaying non-inline bitmap images Vasilij Schneidermann
2014-12-16 18:28 ` Ulf Jasper
[not found] ` <20141216190547.GA1859@odonien.labor.koeln.ccc.de>
2014-12-16 19:44 ` Ulf Jasper
2014-12-17 20:00 ` Ulf Jasper
2014-12-18 3:50 ` YAMAMOTO Mitsuharu [this message]
2014-12-18 13:40 ` Ulf Jasper
[not found] ` <20141218092705.GA1133@odonien.bevuta.com>
2014-12-18 13:44 ` Ulf Jasper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wl1tnx62gm.wl%mituharu@math.s.chiba-u.ac.jp \
--to=mituharu@math.s.chiba-u.ac.jp \
--cc=19373@debbugs.gnu.org \
--cc=hurrus.durrus@gmail.com \
--cc=ulf.jasper@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.