From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: drkm Newsgroups: gmane.emacs.devel Subject: Re: defface location in describe-face Date: Tue, 04 Jan 2005 17:42:04 +0100 Organization: None Message-ID: References: <20050104022247.8315.qmail@web25809.mail.ukl.yahoo.com> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1104857050 19326 80.91.229.6 (4 Jan 2005 16:44:10 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 4 Jan 2005 16:44:10 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 04 17:43:48 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Clrmd-0000la-00 for ; Tue, 04 Jan 2005 17:43:48 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Clrxq-0003Mv-Sp for ged-emacs-devel@m.gmane.org; Tue, 04 Jan 2005 11:55:22 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1ClrxB-0003Bu-1K for emacs-devel@gnu.org; Tue, 04 Jan 2005 11:54:41 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1ClrxA-0003BV-4c for emacs-devel@gnu.org; Tue, 04 Jan 2005 11:54:40 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Clrx9-0003B2-SH for emacs-devel@gnu.org; Tue, 04 Jan 2005 11:54:39 -0500 Original-Received: from [80.91.229.2] (helo=main.gmane.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Clrl0-0001UR-RR for emacs-devel@gnu.org; Tue, 04 Jan 2005 11:42:08 -0500 Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1Clrl0-0004BJ-00 for ; Tue, 04 Jan 2005 17:42:06 +0100 Original-Received: from 202-250.242.81.adsl.skynet.be ([81.242.250.202]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 04 Jan 2005 17:42:06 +0100 Original-Received: from darkman_spam by 202-250.242.81.adsl.skynet.be with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 04 Jan 2005 17:42:06 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 27 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 202-250.242.81.adsl.skynet.be User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3.50 (windows-nt) Cancel-Lock: sha1:sB7EUklY+LZV0fmGV8sJkJU5IOY= X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:31831 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:31831 Stefan writes: >> replaced by (locally binding `find-variable-regexp'): >> (let ((library (or file (symbol-file face 'defface))) >> (find-variable-regexp find-face-regexp)) >> (find-function-search-for-symbol face 'variable library))) > That's ugly. Yes. That's why I pointed it out. And why I added `find-face-noselect' in find-func.el. Initially, I did that trick enclosing the calls to `find-variable-noselect' (ahem). >> But I think `find-func' library should be fixed to handle arbitrary >> kind of symbol (or at least other standard things than functions and >> variables). > Yes, that's what needs to be done. > The rest of the patch looks OK, except that the "loaddefs.el" thingy should > be removed (it's only done for variables, not for functions, and shouldn't > be done for faces either). Ok. I suppose I let you do it (just remove the `when' form). --drkm