* bug#20400: wrong author line in generated ChangeLog
@ 2015-04-21 20:41 Glenn Morris
2015-04-24 14:40 ` Artur Malabarba
2015-04-25 23:43 ` Paul Eggert
0 siblings, 2 replies; 5+ messages in thread
From: Glenn Morris @ 2015-04-21 20:41 UTC (permalink / raw
To: 20400
Package: emacs
Version: 25.0.50
`make ChangeLog' gives me a file containing this:
2015-04-19 Steve Purcell <steve@sanityinc.com>
Steve Purcell <steve@sanityinc.com>
Presumably this is due to a mistake in
http://lists.gnu.org/archive/html/emacs-diffs/2015-04/msg00308.html
Three things to fix IMO:
1) That specific ChangeLog entry
2) The description of Co-authored-by in CONTRIBUTE seems misleading. I
guess it should say something along the lines of "If the commit has
authors other than the one listed in the Author: header (ie, the one
passed to git commit --author")..." rather than "other than yourself".
3) The ChangeLog generation script should avoid listing literally
identical authors twice.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#20400: wrong author line in generated ChangeLog
2015-04-21 20:41 bug#20400: wrong author line in generated ChangeLog Glenn Morris
@ 2015-04-24 14:40 ` Artur Malabarba
2015-04-24 14:49 ` Eli Zaretskii
2015-04-25 23:43 ` Paul Eggert
1 sibling, 1 reply; 5+ messages in thread
From: Artur Malabarba @ 2015-04-24 14:40 UTC (permalink / raw
To: Glenn Morris; +Cc: 20400
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
Sorry about this.
> 2) The description of Co-authored-by in CONTRIBUTE seems misleading. I
> guess it should say something along the lines of "If the commit has
> authors other than the one listed in the Author: header (ie, the one
> passed to git commit --author")..." rather than "other than yourself".
Yes, please. That's exactly what caused my confusion.
CONTRIBUTE should tell us to use the regular git author, and then mention
that the header is available for when additional authors are needed. The
way it is written sounds like you must use the header if the author is not
you.
[-- Attachment #2: Type: text/html, Size: 697 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#20400: wrong author line in generated ChangeLog
2015-04-24 14:40 ` Artur Malabarba
@ 2015-04-24 14:49 ` Eli Zaretskii
2015-04-25 14:41 ` Artur Malabarba
0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2015-04-24 14:49 UTC (permalink / raw
To: bruce.connor.am; +Cc: 20400
> Date: Fri, 24 Apr 2015 15:40:45 +0100
> From: Artur Malabarba <bruce.connor.am@gmail.com>
> Cc: 20400@debbugs.gnu.org
>
> > 2) The description of Co-authored-by in CONTRIBUTE seems misleading. I
> > guess it should say something along the lines of "If the commit has
> > authors other than the one listed in the Author: header (ie, the one
> > passed to git commit --author")..." rather than "other than yourself".
>
> Yes, please. That's exactly what caused my confusion.
> CONTRIBUTE should tell us to use the regular git author, and then mention that
> the header is available for when additional authors are needed. The way it is
> written sounds like you must use the header if the author is not you.
I fixed this, although with a different text than suggested above
(which I find too long and confusing). Let me know if the new text
needs more work.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#20400: wrong author line in generated ChangeLog
2015-04-24 14:49 ` Eli Zaretskii
@ 2015-04-25 14:41 ` Artur Malabarba
0 siblings, 0 replies; 5+ messages in thread
From: Artur Malabarba @ 2015-04-25 14:41 UTC (permalink / raw
To: Eli Zaretskii; +Cc: 20400
Looks fine to me. Thanks Eli.
2015-04-24 15:49 GMT+01:00 Eli Zaretskii <eliz@gnu.org>:
>> Date: Fri, 24 Apr 2015 15:40:45 +0100
>> From: Artur Malabarba <bruce.connor.am@gmail.com>
>> Cc: 20400@debbugs.gnu.org
>>
>> > 2) The description of Co-authored-by in CONTRIBUTE seems misleading. I
>> > guess it should say something along the lines of "If the commit has
>> > authors other than the one listed in the Author: header (ie, the one
>> > passed to git commit --author")..." rather than "other than yourself".
>>
>> Yes, please. That's exactly what caused my confusion.
>> CONTRIBUTE should tell us to use the regular git author, and then mention that
>> the header is available for when additional authors are needed. The way it is
>> written sounds like you must use the header if the author is not you.
>
> I fixed this, although with a different text than suggested above
> (which I find too long and confusing). Let me know if the new text
> needs more work.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#20400: wrong author line in generated ChangeLog
2015-04-21 20:41 bug#20400: wrong author line in generated ChangeLog Glenn Morris
2015-04-24 14:40 ` Artur Malabarba
@ 2015-04-25 23:43 ` Paul Eggert
1 sibling, 0 replies; 5+ messages in thread
From: Paul Eggert @ 2015-04-25 23:43 UTC (permalink / raw
To: 20400-done
I ran 'make change-history', committed the typo fix to ChangeLog.2, and am
marking this as done.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-04-25 23:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-21 20:41 bug#20400: wrong author line in generated ChangeLog Glenn Morris
2015-04-24 14:40 ` Artur Malabarba
2015-04-24 14:49 ` Eli Zaretskii
2015-04-25 14:41 ` Artur Malabarba
2015-04-25 23:43 ` Paul Eggert
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.