From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.bugs Subject: Re: sgml-mode skip tag forward/back bug fix -- followup Date: 29 Apr 2002 17:34:43 -0600 Organization: IHS Engineering, Electronic Systems Development Sender: bug-gnu-emacs-admin@gnu.org Message-ID: References: NNTP-Posting-Host: localhost.gmane.org X-Trace: main.gmane.org 1020123391 8650 127.0.0.1 (29 Apr 2002 23:36:31 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 29 Apr 2002 23:36:31 +0000 (UTC) Return-path: Original-Received: from fencepost.gnu.org ([199.232.76.164]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 172Kh5-0002FO-00 for ; Tue, 30 Apr 2002 01:36:31 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 172Kgu-0003bf-00; Mon, 29 Apr 2002 19:36:20 -0400 Original-Received: from mailbox2.ucsd.edu ([132.239.1.54]) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 172KfM-0003Ua-00 for ; Mon, 29 Apr 2002 19:34:44 -0400 Original-Received: from mail.fu-berlin.de (mail.fu-berlin.de [160.45.11.165]) by mailbox2.ucsd.edu (8.12.1/8.12.1) with ESMTP id g3TNYfrV025204 for ; Mon, 29 Apr 2002 16:34:42 -0700 (PDT) Original-Received: by mail.fu-berlin.de (Smail3.2.0.98) from Curry.ZEDAT.FU-Berlin.DE (160.45.10.36) with esmtp id ; Tue, 30 Apr 2002 01:34:41 +0200 (MEST) Original-Received: by Curry.ZEDAT.FU-Berlin.DE (Smail3.2.0.98) from news.fu-berlin.de with bsmtp id ; Tue, 30 Apr 2002 01:34:40 +0200 (MEST) Original-To: gnu-emacs-bug@moderators.isc.org Original-Path: 170.207.51.80!not-for-mail Original-Newsgroups: gnu.emacs.bug Original-Lines: 28 X-Orig-NNTP-Posting-Host: 170.207.51.80 X-Orig-X-Trace: fu-berlin.de 1020123280 12068539 170.207.51.80 (16 [82742]) X-Newsreader: Gnus v5.3/Emacs 19.34 Errors-To: bug-gnu-emacs-admin@gnu.org X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.0.9 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Bug reports for GNU Emacs, the Swiss army knife of text editors List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.bugs:1038 X-Report-Spam: http://spam.gmane.org/gmane.emacs.bugs:1038 "Mallory, Rich" writes: > Further testing revealed that the bug fix proposed in that email > was incomplete. The complete set of diffs follows, including the > diffs from the original email. The proposed fix works without the > new additions. However, the change to line 687 is needed to > keep up-list from beeping each time function sgml-skip-tag-forward > is executed. (My machine at work has no speaker, so I didn't hear > a beep and ignored the message until I got home.) The original > code for line 683 produces no beep, but the change to line 683 > seems advisable. ... > The changes to lines 683 and 687 are required by the change to > line 676. The latter causes the regexp 're' to match one > additional character, leaving the point after that character. If this > character is '>', the point is outside the tag matched by 're'. In > the original code, the point was inside the tag, and up-list moved > the point to the beginning of the tag. With the point after the > closing '>', up-list can't do that. Why don't you make use of the syntax table, and append "\\>" instead to the tag regexp? That would prevent matching element names that are a prefix of the one to be skipped as desired, and wouldn't match the extra character that necessitates the call to backward-char before up-list. -- Kevin Rodgers