From: Benjamin Rutt <brutt+news@bloomington.in.us>
Subject: Re: [patch] add 'q' key binding to diff
Date: Mon, 02 Feb 2004 09:27:35 -0500 [thread overview]
Message-ID: <wc3llnly2so.fsf@mu.cis.ohio-state.edu> (raw)
In-Reply-To: <wc365f3o5jl.fsf@mu.cis.ohio-state.edu> (Benjamin Rutt's message of "Thu, 22 Jan 2004 19:46:38 -0500")
Benjamin Rutt <brutt+news@bloomington.in.us> writes:
> I was inspired to make this tiny change when I began seriously using
> the recent changes to VC annotate mode that enable browsing etc. It's
> nice to press "D" or "L" on a vc annotate line, and get the diff or
> log message. What isn't nice is the inconsistent ways you need to use
> to quit the respective buffer and navigate back to the VC annotate
> buffer you launched the diff or log view from: for "L", you press "q"
> to quit the buffer, but for "D", you have to do C-x k. This patch
> makes "q" do the same thing in diff-mode as it does when looking at a
> cvs log, and is consistent with some other areas of emacs (browsing
> info, for example, where "q" quits the buffer). Also, "q" is
> currently unused in diff-mode. Let me know if this can be accepted.
Can someone reject or accept this so I don't have to keep waiting for
an answer? :) Thanks,
Benjamin Rutt
> Index: ChangeLog
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/lisp/ChangeLog,v
> retrieving revision 1.5619
> diff -c -r1.5619 ChangeLog
> *** ChangeLog 22 Jan 2004 23:37:46 -0000 1.5619
> --- ChangeLog 23 Jan 2004 00:18:36 -0000
> ***************
> *** 1,3 ****
> --- 1,8 ----
> + 2004-01-22 Benjamin Rutt <brutt@bloomington.in.us>
> +
> + * diff-mode.el (diff-mode-shared-map): Add 'q' key binding as a
> + another way to quit the buffer.
> +
> 2004-01-23 Andre Spiegel <spiegel@gnu.org>
>
> * vc.el (vc-current-line): Function removed. This is now done by
> Index: diff-mode.el
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/lisp/diff-mode.el,v
> retrieving revision 1.53
> diff -c -r1.53 diff-mode.el
> *** diff-mode.el 14 Nov 2003 16:22:36 -0000 1.53
> --- diff-mode.el 23 Jan 2004 00:18:36 -0000
> ***************
> *** 127,133 ****
> ("r" . diff-restrict-view)
> ("R" . diff-reverse-direction)
> ("U" . diff-context->unified)
> ! ("C" . diff-unified->context))
> "Basic keymap for `diff-mode', bound to various prefix keys.")
>
> (easy-mmode-defmap diff-mode-map
> --- 127,134 ----
> ("r" . diff-restrict-view)
> ("R" . diff-reverse-direction)
> ("U" . diff-context->unified)
> ! ("C" . diff-unified->context)
> ! ("q" . quit-window))
> "Basic keymap for `diff-mode', bound to various prefix keys.")
>
> (easy-mmode-defmap diff-mode-map
next prev parent reply other threads:[~2004-02-02 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-23 0:46 [patch] add 'q' key binding to diff Benjamin Rutt
2004-02-02 14:27 ` Benjamin Rutt [this message]
2004-02-02 21:24 ` Benjamin Rutt
2004-02-03 8:27 ` Kai Grossjohann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wc3llnly2so.fsf@mu.cis.ohio-state.edu \
--to=brutt+news@bloomington.in.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.