From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "M. Ian Graham" Newsgroups: gmane.emacs.bugs Subject: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Date: Thu, 28 Apr 2022 06:56:19 +0000 Message-ID: References: <87sfpxhkuz.fsf@fastmail.fm> <87o80lhg9b.fsf@fastmail.fm> Reply-To: "M. Ian Graham" Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29275"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "55149@debbugs.gnu.org" <55149@debbugs.gnu.org>, "monnier@iro.umontreal.ca" To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 28 10:02:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njz6W-0007Qh-FE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 10:02:25 +0200 Original-Received: from localhost ([::1]:33114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njz6V-0001Pk-De for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 04:02:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38080) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njz6B-0001LN-3W for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 04:02:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51299) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njz6A-0007VH-RA for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 04:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1njz6A-0007zf-Ke for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 04:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "M. Ian Graham" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Apr 2022 08:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55149 X-GNU-PR-Package: emacs Original-Received: via spool by 55149-submit@debbugs.gnu.org id=B55149.165113287730670 (code B ref 55149); Thu, 28 Apr 2022 08:02:02 +0000 Original-Received: (at 55149) by debbugs.gnu.org; 28 Apr 2022 08:01:17 +0000 Original-Received: from localhost ([127.0.0.1]:45193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njz5Q-0007ya-Il for submit@debbugs.gnu.org; Thu, 28 Apr 2022 04:01:17 -0400 Original-Received: from mail-4323.proton.ch ([185.70.43.23]:18868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njy4k-0006HL-Oj for 55149@debbugs.gnu.org; Thu, 28 Apr 2022 02:56:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=miangraham.com; s=protonmail3; t=1651128983; bh=k45HIB1CTCeIad03VfsUsuzhU1ITvP7gOo0ZUm/690Q=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=g/5cOgxrEwvG/yO87oEbKaxM62+/7tesaZQNt2nK7j8T7btjWn0Ks7BhVvpgBtc2w ipq38x8sQngWsx/RmzrZ1AIiTMldh2KtX88ZR6fOBUb+ysmMVX4FcINstqImoRGbID yx005QXY7156rXztgmYVdLvqCVkgOwd+llL9ICnSBhDZjDvHdfrYxGrcX3Cn5C0WPE nhYHcGe19Bn6gO3imq4xiYVo+XbREWEBK33S6sxYMgcbz74r1yBULR7nsP7XYfVeJp IxeCue8OQHdhu4/00XuLTgWFRkpjeCkpde5dsQ2vWKgxDkzIHol8/DMfDMDu/JRUs2 ACs4SsTq5n2WA== In-Reply-To: <87o80lhg9b.fsf@fastmail.fm> Feedback-ID: 29547276:user:proton X-Mailman-Approved-At: Thu, 28 Apr 2022 04:01:15 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230846 Archived-At: > Oh, well, the recipe can even be simplyfied to defining just a > do-nothing advice! Ah ha. Return value shenanigans. Here's a no-server test case. --- begin elisp --- (advice-add 'original :after #'original--advice) (defun original () "correct: original return value passes through") (defun original--advice () "broken: advice function's return value is used"= ) (message (original)) --- end elisp --- Output before f30625943e: $ emacs -Q --script bug-recipe.el correct: original return value passes through Output after f30625943e: $ emacs -Q --script bug-recipe.el broken: advice function's return value is used -Ian