From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#14937: vc-bzr.el test fails when bzr installed but using Git checkout of Emacs Date: Tue, 23 Jul 2013 12:04:57 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1374595580 27334 80.91.229.3 (23 Jul 2013 16:06:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Jul 2013 16:06:20 +0000 (UTC) Cc: 14937@debbugs.gnu.org To: Barry OReilly Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 23 18:06:21 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V1f6K-000377-Lw for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jul 2013 18:06:12 +0200 Original-Received: from localhost ([::1]:58053 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1f6K-0001Vh-5w for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jul 2013 12:06:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1f6C-0001Uy-Ke for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2013 12:06:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1f6B-0008DO-Cq for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2013 12:06:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50786) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1f6B-0008DE-7q for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2013 12:06:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1V1f6A-0006sa-5F for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2013 12:06:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jul 2013 16:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14937 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14937-submit@debbugs.gnu.org id=B14937.137459550326264 (code B ref 14937); Tue, 23 Jul 2013 16:06:02 +0000 Original-Received: (at 14937) by debbugs.gnu.org; 23 Jul 2013 16:05:03 +0000 Original-Received: from localhost ([127.0.0.1]:45101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V1f5C-0006pV-JG for submit@debbugs.gnu.org; Tue, 23 Jul 2013 12:05:03 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:40850 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V1f59-0006ox-KX for 14937@debbugs.gnu.org; Tue, 23 Jul 2013 12:04:59 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1V1f57-00040o-HK; Tue, 23 Jul 2013 12:04:57 -0400 X-Spook: Tony Blair Chobetsu bemd Armani Mossad Baranyi SP4 kilo X-Ran: TH9=,rGc$,ibB@##dBc@dC3F6\~x3/ll[Om/$_YLXoHy#p;Al7a/vytAO'xS+k$<~LvEIA X-Hue: red X-Attribution: GM User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:76599 Archived-At: I can't reproduce such a failure, don't see why it should fail in such a case, nor how this change can be correct (see below). Could you show the actual failure message? Barry OReilly wrote: > +(defun vc-bzr-test-p () > + (and (executable-find vc-bzr-program) > + (file-accessible-directory-p ".bzr"))) This looks in whatever random directory the PWD happens to be for a .bzr directory. That can't be right.