From: Ulrich Mueller <ulm@gentoo.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: No support for ImageMagick 7 in emacs-26
Date: Mon, 26 Nov 2018 23:00:48 +0100 [thread overview]
Message-ID: <w6gy39fbisv.fsf@kph.uni-mainz.de> (raw)
In-Reply-To: <83zhtvhh8l.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 26 Nov 2018 19:38:02 +0200")
>>>>> On Mon, 26 Nov 2018, Eli Zaretskii wrote:
>> Sorry, but where do you see a change that could affect behaviour of
>> v6.x? Effectively, the only code change in the consolidated patch is the
>> following in image.c:
>>
>> - MagickRealType color_scale = 65535.0 / QuantumRange;
>> + double quantum_range = QuantumRange;
>> + MagickRealType color_scale = 65535.0 / quantum_range;
> This is one part that I'd rather not do on the release branch
We could put a conditional around it (but it looks silly):
#ifdef HAVE_IMAGEMAGICK7
double quantum_range = QuantumRange;
MagickRealType color_scale = 65535.0 / quantum_range;
#else
MagickRealType color_scale = 65535.0 / QuantumRange;
#fi
> (why is it needed, anyway?).
According to the commit message (commit 42ed35c68b):
* src/image.c (imagemagick_load_image): Use double division, and
eliminate a cast. This avoids a -Wdouble-promotion warning with
GCC 7.3 on Ubuntu 18.04.
> The other one is that inclusion of a header file was moved to a
> different place for some reason. (Yes, I'm being paranoid ;-)
For v6 it still includes <wand/MagickWand.h> and <magick/version.h> at
the same place and in the same order. So unless I am missing something,
nothing was moved at all.
IMHO it would be shortsighted to support only a version that ImageMagick
upstream considers legacy. (And yes, it can be fixed at the distro
level, but that just means duplicate work.)
next prev parent reply other threads:[~2018-11-26 22:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-25 8:26 No support for ImageMagick 7 in emacs-26 Ulrich Mueller
2018-11-25 16:26 ` Eli Zaretskii
2018-11-26 7:38 ` Ulrich Mueller
2018-11-26 17:38 ` Eli Zaretskii
2018-11-26 22:00 ` Ulrich Mueller [this message]
2018-11-26 22:07 ` Andreas Schwab
2018-11-27 5:48 ` Eli Zaretskii
2018-11-27 1:38 ` Paul Eggert
2018-11-27 6:14 ` Eli Zaretskii
2018-11-27 16:35 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w6gy39fbisv.fsf@kph.uni-mainz.de \
--to=ulm@gentoo.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.