all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ulrich Mueller <ulm@gentoo.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 33847@debbugs.gnu.org
Subject: bug#33847: 27.0.50; emacsclient does not find server socket
Date: Wed, 26 Dec 2018 16:14:14 +0100	[thread overview]
Message-ID: <w6gmuos48xl.fsf@kph.uni-mainz.de> (raw)
In-Reply-To: <476852d0-9cd6-a6ae-a11d-bb4d761323da@cs.ucla.edu> (Paul Eggert's message of "Tue, 25 Dec 2018 22:59:08 -0800")

>>>>> On Wed, 26 Dec 2018, Paul Eggert wrote:

> Ulrich Mueller wrote:
>> XDG_RUNTIME_DIR is simply not suitable for the purpose, because (by its
>> specification) it will disappear when the login session ends,

> I think the idea is that XDG_RUNTIME_DIR disappears when all login
> sessions end, so it might survive the current session.

I still don't see why XDG_RUNTIME_DIR would be more secure than using
a directory in TMPDIR. server.el seems to take all necessary precautions
to ensure that the directory is safe:

   server-ensure-safe-dir is a compiled Lisp function in ‘server.el’.

   (server-ensure-safe-dir DIR)

   Make sure DIR is a directory with no race-condition issues.
   Creates the directory if necessary and makes sure:
   - there’s no symlink involved
   - it’s owned by us
   - it’s not readable/writable by anybody else.

In addition, emacsclient checks for the ownership of the socket before
connecting to it.

>> No need for Emacs itself to be setgid, because the directory could
>> be created by calling an auxiliary setgid program (similar to
>> update-game-score).

> That might work, as a solution for people who want Emacs to keep
> running even when they entirely log out.

It would also be rather complicated, and require creation of an emacs
group. Using a directory where the user has write access is easier.
AFAICS, the three candidates for that are TMPDIR, HOME, and
XDG_RUNTIME_DIR.

Emacs 26 uses ${TMPDIR}/emacs${UID}/ or ${HOME}/.emacs.d/server/
depending on the server-use-tcp flag. Emacs 27 will use one of these
two or ${XDG_RUNTIME_DIR} as a default (depending on the environment).
IMHO this is approaching the point where things become unpredictable
and hard to understand for the user. (And making it more customizable
won't make it simpler, I fear.)

If TMPDIR really is insecure (see above), can't the socket be placed
in ${HOME}/.emacs.d/ which is already used in the TCP case? The socket
could be named server-<system-name>, in order to avoid issues with NFS
mounted directories.





  reply	other threads:[~2018-12-26 15:14 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-23  9:48 bug#33847: 27.0.50; emacsclient does not find server socket Ulrich Mueller
2018-12-23 16:20 ` Ulrich Mueller
2018-12-25 21:02 ` Paul Eggert
2018-12-25 23:29   ` Ulrich Mueller
2018-12-26  0:24     ` Paul Eggert
2018-12-26  2:27       ` Ulrich Mueller
2018-12-26  6:59         ` Paul Eggert
2018-12-26 15:14           ` Ulrich Mueller [this message]
2018-12-26 18:32             ` Paul Eggert
2018-12-28  6:37               ` Ulrich Mueller
2018-12-30  6:47                 ` Paul Eggert
2018-12-27  3:38       ` Richard Stallman
2018-12-27 16:42         ` Paul Eggert
2018-12-27 17:13           ` Paul Eggert
2018-12-28  6:19             ` Ulrich Mueller
2018-12-28  6:35               ` Paul Eggert
2018-12-28  6:51                 ` Ulrich Mueller
2018-12-30  6:44                   ` Paul Eggert
2019-01-20 17:59                     ` Ulrich Mueller
2019-02-10  8:37                       ` Ulrich Mueller
2019-02-10  9:48                         ` Eli Zaretskii
2020-08-19 11:05                           ` Lars Ingebrigtsen
2020-08-21 21:28                             ` Paul Eggert
2020-08-22  7:24                               ` Ulrich Mueller
2020-08-22  7:33                                 ` Andreas Schwab
2020-08-22  7:45                                   ` Ulrich Mueller
2020-08-22  8:00                                 ` Eli Zaretskii
2020-08-22 17:51                                 ` Paul Eggert
2020-08-22  7:59                               ` Eli Zaretskii
2020-08-22 17:55                                 ` Paul Eggert
2020-08-22 18:30                                   ` Eli Zaretskii
2020-08-22 21:20                                     ` Paul Eggert
2020-08-23  5:41                                       ` Eli Zaretskii
2021-07-22 13:08                                         ` Lars Ingebrigtsen
2021-07-22 16:45                                           ` Eli Zaretskii
2021-07-22 17:05                                             ` Lars Ingebrigtsen
2021-07-22 17:30                                               ` Eli Zaretskii
2021-07-23 11:31                                                 ` Lars Ingebrigtsen
2021-07-23 11:38                                                   ` Lars Ingebrigtsen
2021-07-23 23:58                                                     ` Paul Eggert
2021-07-24  6:23                                                       ` Eli Zaretskii
2021-07-24  7:48                                                         ` Paul Eggert
2021-07-24  8:25                                                           ` Eli Zaretskii
2021-07-24 23:31                                                             ` Paul Eggert
2021-07-25  6:32                                                               ` Eli Zaretskii
2021-07-25 16:22                                                                 ` Paul Eggert
     [not found]                                                                 ` <a0688fd6-9e73-73d8-6138-3280981abcb5@cs.ucla.edu>
2021-07-25 16:34                                                                   ` Eli Zaretskii
2021-10-04  6:45                                                                   ` Paul Eggert
2021-07-25  7:27                                                               ` Eli Zaretskii
2021-07-24 10:11                                                       ` Lars Ingebrigtsen
2021-07-24 19:37                                                         ` Paul Eggert
2021-07-23 11:58                                                   ` Eli Zaretskii
2021-07-22 18:30                                             ` Ulrich Mueller
2019-04-27  1:41 ` Teika Kazura
2019-04-27  7:56   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=w6gmuos48xl.fsf@kph.uni-mainz.de \
    --to=ulm@gentoo.org \
    --cc=33847@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.