From: Andy Moreton <andrewjmoreton@gmail.com>
To: emacs-devel@gnu.org
Cc: dancol@dancol.org
Subject: Re: Why is custom--inhibit-theme-enable not t by default?
Date: Mon, 18 Jun 2018 15:07:53 +0100 [thread overview]
Message-ID: <vz1y3fc5gsm.fsf@gmail.com> (raw)
In-Reply-To: 86vaahgkvz.fsf@gmail.com
On Sun 17 Jun 2018, Andy Moreton wrote:
> On Tue 12 Jun 2018, dancol@dancol.org wrote:
>
>>>> Date: Mon, 11 Jun 2018 21:14:49 -0700
>>>> From: dancol@dancol.org
>>>>
>>>> A simple require of a package shouldn't have side effects, especially
>>>> not
>>>> ones as drastic as changing the entire appearance of the program.
>>>
>>> I think themes are special in this regard: loading a theme activates
>>> it.
>>>
>>
>> Why did we do it that way? Is it too late to change it? Loading _anything_
>> shouldn't activate it. I don't see a need to carve out a special case for
>> themes.
>>
>> At the very least, we should make custom--inhibit-theme-enable a public
>> variable so people can let-binding something that lets them load theme
>> code normally without the expectation of serious side effects.
>
> The changes you made in commit aabaa9f8c8b7 ("Apply non-user themes only
> when asked") break use of custom faces with use-package. E.g. in gnus:
>
> (use-package gnus
> :custom-face
> (gnus-summary-selected
> ((((class color)) :foreground "Black" :background "PaleGoldenrod")))
> :config
> ;; other setup
> )
>
> The observed symptom is that the faces are not set correctly as specified
> after the :custom-face keyword. However if the same buffer is viewed in
> a new frame then it is displayed with the correct customised faces.
>
> This is a regression introduced by this commit - please take a look.
It appears that the change in cus-face.el in commit aabaa9f8c8b7 did not
match the other hunks and invert the test when changing from
`custom--inhibit-theme-enable' to `custom--should-apply-setting'.
The following patch fixes it:
diff --git a/lisp/cus-face.el b/lisp/cus-face.el
index 039c1fafa7..54f5d51358 100644
--- a/lisp/cus-face.el
+++ b/lisp/cus-face.el
@@ -342,7 +342,7 @@ custom-theme-set-faces
;; is aliased to.
(if (get face 'face-alias)
(setq face (get face 'face-alias)))
- (if (custom--should-apply-setting theme)
+ (if (not (custom--should-apply-setting theme))
;; Just update theme settings.
(custom-push-theme 'theme-face face theme 'set spec)
;; Update theme settings and set the face spec.
next prev parent reply other threads:[~2018-06-18 14:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 4:14 Why is custom--inhibit-theme-enable not t by default? dancol
2018-06-12 15:23 ` Eli Zaretskii
2018-06-12 15:42 ` dancol
2018-06-12 16:37 ` Eli Zaretskii
[not found] ` <<83vaao3qrn.fsf@gnu.org>
2018-06-12 19:54 ` Drew Adams
2018-06-13 13:47 ` Basil L. Contovounesios
2018-06-13 14:22 ` Drew Adams
2018-06-13 16:55 ` Disabling custom themes (was: Why is custom--inhibit-theme-enable not t by default?) Basil L. Contovounesios
2018-06-13 17:16 ` Drew Adams
2018-06-13 17:21 ` Disabling custom themes Eric Abrahamsen
2018-06-13 17:30 ` Daniel Colascione
2018-06-14 2:34 ` Why is custom--inhibit-theme-enable not t by default? Richard Stallman
2018-06-14 3:26 ` Stefan Monnier
2018-06-14 14:21 ` Drew Adams
2018-06-14 18:02 ` Stefan Monnier
2018-06-14 18:16 ` Drew Adams
2018-06-14 18:30 ` Stefan Monnier
2018-06-14 18:41 ` Basil L. Contovounesios
2018-06-14 20:09 ` Stefan Monnier
2018-06-13 14:01 ` Basil L. Contovounesios
2018-06-17 21:31 ` Andy Moreton
2018-06-18 14:07 ` Andy Moreton [this message]
2018-06-19 14:49 ` Daniel Colascione
2018-06-12 18:24 ` Basil L. Contovounesios
2018-06-13 2:16 ` Richard Stallman
2018-06-13 13:56 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vz1y3fc5gsm.fsf@gmail.com \
--to=andrewjmoreton@gmail.com \
--cc=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.