From: Andy Moreton <andrewjmoreton@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: bat-mode: Inconsistent fontification. Consider using font-lock-function-name-face
Date: Mon, 09 Sep 2019 11:48:09 +0100 [thread overview]
Message-ID: <vz1y2yxwxsm.fsf@gmail.com> (raw)
In-Reply-To: cfa93f75-bf75-788a-f9f0-ef38d956c2db@secure.kjonigsen.net
On Mon 09 Sep 2019, Jostein Kjønigsen wrote:
> Hey everyone.
>
> Right now Emacs' bat-mode has an inconsistent use of faces, both internally
> and w.r.t. to the rest of the Emacs universe.
>
> In batch files you can create "labels". A label is a line whose character is :
> followed by alpha-numerical characters.
>
> :EXAMPLE_LABEL
>
> These labels are often used via GOTO-statements for direct control flow, but
> they can also be used via CALL-statements and then they work like
> functions/subroutines and control is eventually returned to the caller.
>
> CALL :subroutine param1 param2
> GOTO :EOF
> etc
>
> Right now labels have one custom-face defined for bat-mode (bat-label-face),
> and all -uses- of this label via GOTO or CALL-statements has this label
> highlighted using font-lock-constant-face.
>
> My proposal is that we change both these rules to instead be
> font-lock-function-name-face. This solves both constency-problems:
That is not consistent with c-mode, which uses font-lock-constant-face
for both goto statements and labels.
AndyM
next prev parent reply other threads:[~2019-09-09 10:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 8:49 bat-mode: Inconsistent fontification. Consider using font-lock-function-name-face Jostein Kjønigsen
2019-09-09 10:48 ` Andy Moreton [this message]
2019-09-09 16:09 ` Eli Zaretskii
2019-09-09 17:34 ` Jostein Kjønigsen
2019-09-09 18:10 ` Eli Zaretskii
2019-09-09 19:26 ` Jostein Kjønigsen
2019-09-09 20:32 ` Clément Pit-Claudel
2019-09-09 21:41 ` Stefan Monnier
2019-09-10 4:29 ` Jostein Kjønigsen
2019-09-10 12:48 ` Stefan Monnier
2019-09-10 14:54 ` Eli Zaretskii
2019-09-10 16:56 ` Jostein Kjønigsen
2019-09-10 18:10 ` Eli Zaretskii
2019-09-10 19:49 ` Michael Albinus
2019-09-18 19:21 ` Jostein Kjønigsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vz1y2yxwxsm.fsf@gmail.com \
--to=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.