From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#27986: 26.0.50; 'rename-file' can rename files without confirmation Date: Tue, 15 Aug 2017 13:45:02 +0100 Message-ID: References: <61980dde-3d68-7200-e7f4-98f62e410060@cs.ucla.edu> <0e80a1cf-8217-9e9a-a00f-9fdbd6575fc4@cs.ucla.edu> <0a79089f-36ed-8183-a3bf-6cfa32cb9028@cs.ucla.edu> <4dfc78db-b550-4cc6-efad-67b7c57c3cce@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1502801186 18558 195.159.176.226 (15 Aug 2017 12:46:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 15 Aug 2017 12:46:26 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (windows-nt) To: 27986@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 15 14:46:22 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhbEk-0004a4-68 for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Aug 2017 14:46:22 +0200 Original-Received: from localhost ([::1]:59007 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhbEq-0006l1-GD for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Aug 2017 08:46:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhbEU-0006ap-1o for bug-gnu-emacs@gnu.org; Tue, 15 Aug 2017 08:46:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhbER-0007S1-Fn for bug-gnu-emacs@gnu.org; Tue, 15 Aug 2017 08:46:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57358) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dhbER-0007Rj-CK for bug-gnu-emacs@gnu.org; Tue, 15 Aug 2017 08:46:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dhbEQ-0005fp-1V for bug-gnu-emacs@gnu.org; Tue, 15 Aug 2017 08:46:03 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Aug 2017 12:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27986 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.150280114021799 (code B ref -1); Tue, 15 Aug 2017 12:46:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Aug 2017 12:45:40 +0000 Original-Received: from localhost ([127.0.0.1]:37806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhbE3-0005fX-MV for submit@debbugs.gnu.org; Tue, 15 Aug 2017 08:45:39 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:32839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhbE2-0005fP-7Z for submit@debbugs.gnu.org; Tue, 15 Aug 2017 08:45:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhbDw-0006rc-0f for submit@debbugs.gnu.org; Tue, 15 Aug 2017 08:45:32 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:52583) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dhbDv-0006rY-Tb for submit@debbugs.gnu.org; Tue, 15 Aug 2017 08:45:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhbDt-0006GV-Oj for bug-gnu-emacs@gnu.org; Tue, 15 Aug 2017 08:45:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhbDr-0006ol-6o for bug-gnu-emacs@gnu.org; Tue, 15 Aug 2017 08:45:29 -0400 Original-Received: from [195.159.176.226] (port=41440 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dhbDq-0006nI-V9 for bug-gnu-emacs@gnu.org; Tue, 15 Aug 2017 08:45:27 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dhbDd-00010o-KW for bug-gnu-emacs@gnu.org; Tue, 15 Aug 2017 14:45:13 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 23 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:hhrFtBSMEUBRAMTrgpIBYiOATik= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135772 Archived-At: On Mon 14 Aug 2017, Paul Eggert wrote: > Paul Eggert wrote: >> I installed the patch on 'master' to help you do that. > > After rereading the Apple manual I installed the attached further patch into > master, so please try updating to the latest master before testing. This patch breaks the Windows build for mingw64: ../../src/fileio.c: In function 'Frename_file': ../../src/fileio.c:2300:41: error: duplicate case value case EEXIST: case EINVAL: case ENOSYS: case ENOTSUP: ^~~~ ../../src/fileio.c:2300:28: note: previously used here case EEXIST: case EINVAL: case ENOSYS: case ENOTSUP: ^~~~ A brief look suggests that the inclusion of ms-w32.h in conf_post.h is the culprit, as it defines some error numbers before errno.h is included, and thus overrides the conditional definitions in errno.h. AndyM