From: Andy Moreton <andrewjmoreton@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: Testing native image scaling
Date: Thu, 28 Mar 2019 18:06:17 +0000 [thread overview]
Message-ID: <vz1tvfm50x2.fsf@gmail.com> (raw)
In-Reply-To: 83va03j8c0.fsf@gnu.org
On Thu 28 Mar 2019, Eli Zaretskii wrote:
>> Date: Thu, 28 Mar 2019 11:26:46 +0900
>> From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
>>
>> > > It seems to work, but maybe I don't know what and how to check. Can
>> > > you show what I should expect to see with and without the :scale
>> > > attribute, in "emacs -Q"?
>> > >
>> > > Thanks.
>> >
>> > I would expect a sliced image to be composed of a grid of tiled images
>> > instead of a single image, but to have the same visual appearance as the
>> > original image. The w32 code does not get this right.
>>
>> Thanks for the screenshot. That's what I suspected from the code in
>> w32term.c and the documentation of StretchBlt. Below is the
>> screenshot on Xrender, and it should be the expected result. The
>> cursor is at the last row and the last column of the sliced image.
>
> Thanks, I think I fixed this now.
Confirmed.
Should the <kp-subtract> and <kp-add> bindings for `image-decrease-size'
and `image-increase-size' be adjusted to handle sliced images ?
Also, in w32 builds of emacs-26 'M-X image-rotate' on a (non-sliced)
image logs a message: "image--get-imagemagick-and-warn: Cannot rescale
images without ImageMagick support", whereas on master it does nothing.
Is image rotation expected to work on Windows ?
AndyM
next prev parent reply other threads:[~2019-03-28 18:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-19 9:31 Testing native image scaling Eli Zaretskii
2019-01-19 21:45 ` Alan Third
2019-01-20 16:05 ` Eli Zaretskii
2019-01-20 19:26 ` Alan Third
2019-01-20 19:41 ` Eli Zaretskii
2019-01-20 20:19 ` Alan Third
2019-03-27 2:35 ` YAMAMOTO Mitsuharu
2019-03-27 17:09 ` Eli Zaretskii
2019-03-27 18:35 ` Andy Moreton
2019-03-27 18:42 ` Eli Zaretskii
2019-03-27 19:06 ` Andy Moreton
2019-03-27 19:34 ` Andy Moreton
2019-03-28 2:26 ` YAMAMOTO Mitsuharu
2019-03-28 16:02 ` Eli Zaretskii
2019-03-28 18:06 ` Andy Moreton [this message]
2019-03-28 18:19 ` Eli Zaretskii
2019-03-28 19:29 ` Andy Moreton
2019-03-28 20:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vz1tvfm50x2.fsf@gmail.com \
--to=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.