From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Use of "Action stamps" in commit messages Date: Fri, 13 Jul 2018 13:59:32 +0100 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1531486732 1822 195.159.176.226 (13 Jul 2018 12:58:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 13 Jul 2018 12:58:52 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 13 14:58:48 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fdxep-0000Nf-Oz for ged-emacs-devel@m.gmane.org; Fri, 13 Jul 2018 14:58:47 +0200 Original-Received: from localhost ([::1]:37172 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdxgw-0000L3-Lx for ged-emacs-devel@m.gmane.org; Fri, 13 Jul 2018 09:00:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdxft-0000JQ-Rp for emacs-devel@gnu.org; Fri, 13 Jul 2018 08:59:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdxfp-0005lv-VM for emacs-devel@gnu.org; Fri, 13 Jul 2018 08:59:53 -0400 Original-Received: from [195.159.176.226] (port=41432 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fdxfp-0005ir-Og for emacs-devel@gnu.org; Fri, 13 Jul 2018 08:59:49 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fdxdc-0007QH-1j for emacs-devel@gnu.org; Fri, 13 Jul 2018 14:57:32 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 36 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:b2N9biIf5d9CDnPjGVTAW4kYt2Q= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227332 Archived-At: On Fri 13 Jul 2018, Noam Postavsky wrote: > .On 12 July 2018 at 11:34, Basil L. Contovounesios wrote: > >> from CONTRIBUTE: >> >> One way to identify revisions is by quoting their summary line. >> Another is with an action stamp - an RFC3339 date followed by ! >> followed by the committer's email - for example, >> "2014-01-16T05:43:35Z!esr@thyrsus.com". > > This reminds that I'd like to remove this "Action stamp" thing as > commit message convention. Action stamps are fine for what they were > designed for: acting as a unique commit id for the repository > conversion software "reposurgeon", but they are not very friendly to > human readers. > > A date followed by the summary line is sufficient to identify a commit > in a vc system agnostic way, reads nicer, and gives more info up front > to a human. > > See also Bug#20609. > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20609 The Linux kernel convention is nicer: the (shortened) commit id, followed by a space and the commit summary line, e.g. Fixes: 1222ff5275 ("Don't skip epg-tests even with gpg 2.0 (Bug#23561)") This ensures that the format is human readable, is easy to parse for scripting, and identifies the right commit even if the shortened commit id is not unique. AndyM