From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#34373: Acknowledgement (26.1; Missing range check in rx-submatch-n) Date: Fri, 08 Feb 2019 15:05:57 +0000 Message-ID: References: <92032ECD-6C45-4820-829F-55194CEC885E@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="129960"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: 34373@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 08 16:08:34 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gs7lZ-000Xgh-Hh for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Feb 2019 16:08:33 +0100 Original-Received: from localhost ([127.0.0.1]:57797 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gs7lY-0003ge-90 for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Feb 2019 10:08:32 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gs7k8-0002a1-8X for bug-gnu-emacs@gnu.org; Fri, 08 Feb 2019 10:07:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gs7k7-0004r2-6d for bug-gnu-emacs@gnu.org; Fri, 08 Feb 2019 10:07:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40759) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gs7k7-0004qh-2b for bug-gnu-emacs@gnu.org; Fri, 08 Feb 2019 10:07:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gs7k6-00087b-Hb for bug-gnu-emacs@gnu.org; Fri, 08 Feb 2019 10:07:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Feb 2019 15:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.154963837431140 (code B ref -1); Fri, 08 Feb 2019 15:07:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 8 Feb 2019 15:06:14 +0000 Original-Received: from localhost ([127.0.0.1]:40037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gs7jJ-00086C-Ok for submit@debbugs.gnu.org; Fri, 08 Feb 2019 10:06:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gs7jI-000861-Nw for submit@debbugs.gnu.org; Fri, 08 Feb 2019 10:06:12 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:37679) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gs7jD-00046l-M3 for submit@debbugs.gnu.org; Fri, 08 Feb 2019 10:06:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gs7jC-0001hn-N9 for bug-gnu-emacs@gnu.org; Fri, 08 Feb 2019 10:06:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gs7jC-000458-1f for bug-gnu-emacs@gnu.org; Fri, 08 Feb 2019 10:06:06 -0500 Original-Received: from [195.159.176.226] (port=35490 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gs7jB-000443-RD for bug-gnu-emacs@gnu.org; Fri, 08 Feb 2019 10:06:05 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1gs7j9-000UAO-Lh for bug-gnu-emacs@gnu.org; Fri, 08 Feb 2019 16:06:03 +0100 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:y9X3FVd2HA29wrOVNcLY+gViHD8= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155262 Archived-At: On Thu 07 Feb 2019, Mattias Engdegård wrote: > Patch. > > From cc7bbab39595b117f6f2ed2bcf5ea1782060e574 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Mattias=20Engdeg=C3=A5rd?= > Date: Thu, 7 Feb 2019 19:05:06 +0100 > Subject: [PATCH] Check validity of rx submatch-n number > > * lisp/emacs-lisp/rx.el (rx-submatch): Type and range check (Bug#34373). > --- > lisp/emacs-lisp/rx.el | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lisp/emacs-lisp/rx.el b/lisp/emacs-lisp/rx.el > index 8b4551d0d3..d47beed975 100644 > --- a/lisp/emacs-lisp/rx.el > +++ b/lisp/emacs-lisp/rx.el > @@ -705,6 +705,8 @@ FORM is either `(repeat N FORM1)' or `(repeat N M FORMS...)'." > (defun rx-submatch-n (form) > "Parse and produce code from FORM, which is `(submatch-n N ...)'." > (let ((n (nth 1 form))) > + (unless (and (integerp n) (> n 0)) > + (error "rx `submatch-n' argument must be positive")) > (concat "\\(?" (number-to-string n) ":" > (if (= 3 (length form)) > ;; Only one sub-form. You could use (natnump n) instead. AndyM