From: Andy Moreton <andrewjmoreton@gmail.com>
To: 34373@debbugs.gnu.org
Subject: bug#34373: Acknowledgement (26.1; Missing range check in rx-submatch-n)
Date: Fri, 08 Feb 2019 15:05:57 +0000 [thread overview]
Message-ID: <vz1sgwys4kq.fsf@gmail.com> (raw)
In-Reply-To: <C266781B-8A07-423F-8DC6-7FA166D681E8@acm.org>
On Thu 07 Feb 2019, Mattias Engdegård wrote:
> Patch.
>
> From cc7bbab39595b117f6f2ed2bcf5ea1782060e574 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Mattias=20Engdeg=C3=A5rd?= <mattiase@acm.org>
> Date: Thu, 7 Feb 2019 19:05:06 +0100
> Subject: [PATCH] Check validity of rx submatch-n number
>
> * lisp/emacs-lisp/rx.el (rx-submatch): Type and range check (Bug#34373).
> ---
> lisp/emacs-lisp/rx.el | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lisp/emacs-lisp/rx.el b/lisp/emacs-lisp/rx.el
> index 8b4551d0d3..d47beed975 100644
> --- a/lisp/emacs-lisp/rx.el
> +++ b/lisp/emacs-lisp/rx.el
> @@ -705,6 +705,8 @@ FORM is either `(repeat N FORM1)' or `(repeat N M FORMS...)'."
> (defun rx-submatch-n (form)
> "Parse and produce code from FORM, which is `(submatch-n N ...)'."
> (let ((n (nth 1 form)))
> + (unless (and (integerp n) (> n 0))
> + (error "rx `submatch-n' argument must be positive"))
> (concat "\\(?" (number-to-string n) ":"
> (if (= 3 (length form))
> ;; Only one sub-form.
You could use (natnump n) instead.
AndyM
next prev parent reply other threads:[~2019-02-08 15:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 18:01 bug#34373: 26.1; Missing range check in rx-submatch-n Mattias Engdegård
[not found] ` <handler.34373.B.154956253124084.ack@debbugs.gnu.org>
2019-02-07 18:08 ` bug#34373: Acknowledgement (26.1; Missing range check in rx-submatch-n) Mattias Engdegård
2019-02-08 15:05 ` Andy Moreton [this message]
2019-02-16 11:14 ` Mattias Engdegård
2019-06-23 18:20 ` Lars Ingebrigtsen
2019-06-23 18:34 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vz1sgwys4kq.fsf@gmail.com \
--to=andrewjmoreton@gmail.com \
--cc=34373@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.