From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Merging bignum to master Date: Wed, 15 Aug 2018 16:46:46 +0100 Message-ID: References: <877ekwu1mn.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1534348003 9779 195.159.176.226 (15 Aug 2018 15:46:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 15 Aug 2018 15:46:43 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 15 17:46:39 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fpy0J-0002Lt-AV for ged-emacs-devel@m.gmane.org; Wed, 15 Aug 2018 17:46:35 +0200 Original-Received: from localhost ([::1]:50253 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fpy2P-0007sA-Dc for ged-emacs-devel@m.gmane.org; Wed, 15 Aug 2018 11:48:45 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fpy1H-0007iq-J9 for emacs-devel@gnu.org; Wed, 15 Aug 2018 11:48:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fpy0o-0008F1-HO for emacs-devel@gnu.org; Wed, 15 Aug 2018 11:47:32 -0400 Original-Received: from [195.159.176.226] (port=40215 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fpy0n-00089N-UE for emacs-devel@gnu.org; Wed, 15 Aug 2018 11:47:06 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fpxyW-0008VA-4P for emacs-devel@gnu.org; Wed, 15 Aug 2018 17:44:44 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 34 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:SvKUSoFTKbJXcWzi2DyO8j8emh0= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228558 Archived-At: On Sat 11 Aug 2018, Tom Tromey wrote: > I'm merging bignum to master now, then I'm going to delete the > now-obsolete feature branch. Please report any problems you find. I've noticed a bug in bignumcompare for 64bit Windows: it handles large positive fixnums correctly, but not large negative fixnums. A patch liek this should fix it: AndyM diff --git a/src/data.c b/src/data.c index a1215b9d6b..c89fa3cf51 100644 --- a/src/data.c +++ b/src/data.c @@ -2409,7 +2409,7 @@ bignumcompare (Lisp_Object num1, Lisp_Object num2, } else if (FIXNUMP (num2)) { - if (sizeof (EMACS_INT) > sizeof (long) && XFIXNUM (num2) > LONG_MAX) + if (sizeof (EMACS_INT) > sizeof (long)) { mpz_t tem; mpz_init (tem); @@ -2440,7 +2440,7 @@ bignumcompare (Lisp_Object num1, Lisp_Object num2, else { eassume (FIXNUMP (num1)); - if (sizeof (EMACS_INT) > sizeof (long) && XFIXNUM (num1) > LONG_MAX) + if (sizeof (EMACS_INT) > sizeof (long)) { mpz_t tem; mpz_init (tem);