From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: syntax based indentation for SQL files (ELPA package proposal) Date: Tue, 02 Oct 2018 14:48:40 +0100 Message-ID: References: <808t48ny4y.fsf@gmail.com> <86a7nxb8p8.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1538488019 24017 195.159.176.226 (2 Oct 2018 13:46:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 2 Oct 2018 13:46:59 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 02 15:46:55 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7L0p-00068T-0g for ged-emacs-devel@m.gmane.org; Tue, 02 Oct 2018 15:46:55 +0200 Original-Received: from localhost ([::1]:43824 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7L2v-00076t-Ht for ged-emacs-devel@m.gmane.org; Tue, 02 Oct 2018 09:49:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7L2l-00076g-V2 for emacs-devel@gnu.org; Tue, 02 Oct 2018 09:48:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7L2g-0001y3-9d for emacs-devel@gnu.org; Tue, 02 Oct 2018 09:48:55 -0400 Original-Received: from [195.159.176.226] (port=35591 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g7L2g-0001xX-2t for emacs-devel@gnu.org; Tue, 02 Oct 2018 09:48:50 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1g7L0V-0005nV-MV for emacs-devel@gnu.org; Tue, 02 Oct 2018 15:46:35 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 21 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:lOCfuGL4UUVcQvnfMTSxFdp7pq4= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230190 Archived-At: On Tue 02 Oct 2018, Stefan Monnier wrote: >> This patch looks like it has been applied in the wrong place. Emacs >> builtin code should not depend on an external package. Why did you add >> this change into emacs, rather than the package that defines >> sqind-minor-mode ? > > It doesn't actually depend on sql-indent. It just makes use of it > when available. Given that sql-indent is in GNU ELPA, I think this is > perfectly acceptable (and I'm pretty sure we have other similar cases > already in emacs.git, some of which for packages that aren't even in > GNU ELPA). This is still the wrong way around though: the customisation is only needed by users of sqind-minor-mode, and otherwise adds bloat (and possibly bugs) to emacs core, for no benefit to any other users. This approach is misguided. The customisation to support the GNU ELPA package should be in the GNU ELPA package, not in emacs core. AndyM