From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: send new reply from gnus hangs Date: Mon, 10 Jun 2019 12:52:25 +0100 Message-ID: References: <87r285nhxb.fsf@telefonica.net> <87k1duml43.fsf@telefonica.net> <87sgsiwehh.fsf@telefonica.net> <87k1du744k.fsf@telefonica.net> <87h88y8ibl.fsf@telefonica.net> <878suas5wv.fsf@telefonica.net> <87d0jmuyrj.fsf@telefonica.net> <87imtetju1.fsf@telefonica.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="241743"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 10 13:53:50 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1haIs1-0010jH-Mv for ged-emacs-devel@m.gmane.org; Mon, 10 Jun 2019 13:53:49 +0200 Original-Received: from localhost ([::1]:44772 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haIrz-00066v-Nj for ged-emacs-devel@m.gmane.org; Mon, 10 Jun 2019 07:53:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51401) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haIqv-0005zY-6N for emacs-devel@gnu.org; Mon, 10 Jun 2019 07:52:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1haIqu-0002oA-7S for emacs-devel@gnu.org; Mon, 10 Jun 2019 07:52:41 -0400 Original-Received: from [195.159.176.226] (port=41134 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1haIqs-0002j2-EP for emacs-devel@gnu.org; Mon, 10 Jun 2019 07:52:40 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1haIql-000zFh-4p for emacs-devel@gnu.org; Mon, 10 Jun 2019 13:52:31 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:1PO2EiVw74S60kgzD9UUzrV+Xac= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237397 Archived-At: On Mon 10 Jun 2019, Óscar Fuentes wrote: > Confirmed, reverting that commit fixes the problem. > >> Óscar Fuentes writes: >> >> The problematic commit is >> >> master e51adfbdb7587c2b0b5ba154be210b30db82b4ea >> Author: Oleh Krehel >> AuthorDate: Thu Jun 6 16:01:10 2019 +0200 >> Commit: Oleh Krehel >> CommitDate: Thu Jun 6 16:01:10 2019 +0200 Thanks Óscar, that appears to be the problem. Looking at that commit, one call site calls `error' to abort sending the message, so the return value does not matter, but the other uses do-posting to set the return value from the `check-message' form, which is used by its caller. AndyM