From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#36237: Support (rx (and (regexp EXPR) (regexp-quote EXPR))) Date: Wed, 26 Jun 2019 13:23:53 +0100 Message-ID: References: <87fto9yawl.fsf@gmail.com> <385FA4F7-7FB5-43A2-B571-CFBA20B24123@acm.org> <87tvcmwe6b.fsf@gmail.com> <87o92tw13b.fsf@gmail.com> <877e9duvg9.fsf@gmail.com> <5B00DCD9-0718-44AF-89C1-110CFDC17444@acm.org> <87ef3ktidf.fsf@gmail.com> <87ftnxrtdy.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="169546"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: 36237@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 26 14:29:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hg72x-000hvx-PK for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2019 14:29:07 +0200 Original-Received: from localhost ([::1]:39712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hg72w-0003h2-Cn for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2019 08:29:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52955) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hg6zF-0000hP-Ko for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 08:25:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hg6zB-0006M2-0N for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 08:25:15 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49141) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hg6z0-00060X-0Y for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 08:25:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hg6yz-0003AS-QE for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 08:25:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87v9x6xvml.fsf@gmail.com> Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jun 2019 12:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.156155185912121 (code B ref -1); Wed, 26 Jun 2019 12:25:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Jun 2019 12:24:19 +0000 Original-Received: from localhost ([127.0.0.1]:34452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg6yI-00039R-On for submit@debbugs.gnu.org; Wed, 26 Jun 2019 08:24:18 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:43713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg6yG-00039J-PE for submit@debbugs.gnu.org; Wed, 26 Jun 2019 08:24:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52789) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hg6yE-0008BR-TU for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 08:24:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hg6yD-0004R0-7u for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 08:24:14 -0400 Original-Received: from 195-159-176-226.customer.powertech.no ([195.159.176.226]:44394 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hg6yC-00042T-RR for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 08:24:13 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hg6xz-000bj4-F8 for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 14:23:59 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:9qTQrdvV92z9qeW2wasGtQZkn64= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161481 Archived-At: On Tue 25 Jun 2019, Noam Postavsky wrote: > tags 36237 fixed > close 36237 27.1 > quit > >> I'll wait a few more days in case something else comes up. > > Pushed to master. > > b59ffd2290 2019-06-25T22:00:03-04:00 "Support (rx (and (regexp EXPR) (literal EXPR))) (Bug#36237)" > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=b59ffd2290ff744ca4e7cc2748ba6b66fb2f99f1 With "emacs -Q" from emacs-26: (setq foo (rx (group (or "abc" "def")))) => "\\(\\(?:abc\\|def\\)\\)" (setq bar (rx-to-string `(regexp ,foo))) => "\\(?:\\(\\(?:abc\\|def\\)\\)\\)" (setq bar (rx (regexp foo))) => error "rx form ‘regexp’ requires args satisfying ‘stringp’" With "emacs -Q from master: (setq foo (rx (group (or "abc" "def")))) => "\\(\\(?:abc\\|def\\)\\)" (setq bar (rx-to-string `(regexp ,foo))) => ("\\(?:" "\\)") ; unexpected result (setq bar (rx (regexp foo))) => "\\(?:\\(\\(?:abc\\|def\\)\\)\\)" Please fix this regression. AndyM